Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 311953003: Set /SUBSYSTEM down to 5.02 on x64 to more closely match x86 (Closed)

Created:
6 years, 6 months ago by scottmg
Modified:
6 years, 6 months ago
Reviewers:
jschuh, Will Harris
CC:
chromium-reviews
Visibility:
Public.

Description

Set /SUBSYSTEM down to 5.02 on x64 to more closely match x86 This makes us get XP/Server 2003 compatible metrics for window sizes and so indirectly fixes pixels being cut off at the top of the window. (Server 2003 compatible metrics make us match x86 behaviour, and since we need to maintain XP subsystem there indefinitely, I can sort of rationalize it on that basis.) R=jschuh@chromium.org, wfh@chromium.org BUG=361720 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274853

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M build/common.gypi View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
scottmg
6 years, 6 months ago (2014-06-04 02:24:06 UTC) #1
jschuh
slightly dirty lgtm
6 years, 6 months ago (2014-06-04 03:07:36 UTC) #2
jschuh
The CQ bit was checked by jschuh@chromium.org
6 years, 6 months ago (2014-06-04 03:07:46 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottmg@chromium.org/311953003/1
6 years, 6 months ago (2014-06-04 03:09:36 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_triggered_tests on tryserver.chromium ...
6 years, 6 months ago (2014-06-04 04:24:15 UTC) #5
Will Harris
lgtm but now you need to test this on Windows XP 64-bit
6 years, 6 months ago (2014-06-04 04:38:06 UTC) #6
scottmg
On 2014/06/04 04:38:06, Will Harris wrote: > lgtm but now you need to test this ...
6 years, 6 months ago (2014-06-04 04:42:57 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-04 05:34:27 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_triggered_tests on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered_tests/builds/159561)
6 years, 6 months ago (2014-06-04 05:34:28 UTC) #9
PhistucK
On 2014/06/04 04:38:06, Will Harris wrote: > lgtm but now you need to test this ...
6 years, 6 months ago (2014-06-04 14:07:34 UTC) #10
jschuh
On 2014/06/04 14:07:34, PhistucK wrote: > On 2014/06/04 04:38:06, Will Harris wrote: > > lgtm ...
6 years, 6 months ago (2014-06-04 14:18:20 UTC) #11
scottmg
The CQ bit was checked by scottmg@chromium.org
6 years, 6 months ago (2014-06-04 15:48:16 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottmg@chromium.org/311953003/1
6 years, 6 months ago (2014-06-04 15:48:49 UTC) #13
commit-bot: I haz the power
6 years, 6 months ago (2014-06-04 17:16:07 UTC) #14
Message was sent while issue was closed.
Change committed as 274853

Powered by Google App Engine
This is Rietveld 408576698