Chromium Code Reviews

Issue 311953002: GN: //base should not depend on //base/allocator on mac (Closed)

Created:
6 years, 6 months ago by jamesr
Modified:
6 years, 6 months ago
Reviewers:
brettw
CC:
chromium-reviews, erikwright+watch_chromium.org
Visibility:
Public.

Description

GN: //base should not depend on //base/allocator on mac We don't use tcmalloc or the allocator target on OS X Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274797

Patch Set 1 #

Patch Set 2 : switch in build/config/allocator.gni instead of targets #

Unified diffs Side-by-side diffs Stats (+1 line, -1 line)
M build/config/allocator.gni View 1 chunk +1 line, -1 line 0 comments

Messages

Total messages: 6 (0 generated)
jamesr
In the gyp build this is more complicated because of the use_allocator and win_use_allocator_shim gyp ...
6 years, 6 months ago (2014-06-03 20:07:31 UTC) #1
jamesr
PTAL
6 years, 6 months ago (2014-06-03 23:50:24 UTC) #2
brettw
lgtm
6 years, 6 months ago (2014-06-04 04:36:41 UTC) #3
jamesr
The CQ bit was checked by jamesr@chromium.org
6 years, 6 months ago (2014-06-04 04:45:23 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamesr@chromium.org/311953002/20001
6 years, 6 months ago (2014-06-04 04:46:46 UTC) #5
commit-bot: I haz the power
6 years, 6 months ago (2014-06-04 12:45:45 UTC) #6
Message was sent while issue was closed.
Change committed as 274797

Powered by Google App Engine