Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1277)

Unified Diff: content/browser/media/webrtc_browsertest.cc

Issue 311943002: Same shutdown process for content_browsertests on android/non android. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Another merge attempt. Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/browser_main_runner.cc ('k') | content/common/gpu/media/gpu_video_decode_accelerator.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/media/webrtc_browsertest.cc
diff --git a/content/browser/media/webrtc_browsertest.cc b/content/browser/media/webrtc_browsertest.cc
index 9a003a4814cb400fd9eb2b85fabe6e73166cb8d0..a7ae8bee0ccf2901845b4efda0b1233ac081946e 100644
--- a/content/browser/media/webrtc_browsertest.cc
+++ b/content/browser/media/webrtc_browsertest.cc
@@ -47,18 +47,6 @@ class WebRtcBrowserTest : public WebRtcContentBrowserTest,
command_line->AppendSwitch(switches::kDisableAudioTrackProcessing);
}
- virtual void TearDownOnMainThread() OVERRIDE {
-#if defined(OS_ANDROID)
- // TODO(phoglund): this is a ugly workaround to let the IO thread
- // finish its work. The reason we need this on Android is that
- // content_browsertests tearDown logic is broken with respect
- // to threading, which causes the IO thread to compete with the
- // teardown. See http://crbug.com/362852. I also tried with 2
- // seconds, but that isn't enough.
- base::PlatformThread::Sleep(base::TimeDelta::FromSeconds(5));
-#endif
- }
-
// Convenience function since most peerconnection-call.html tests just load
// the page, kick off some javascript and wait for the title to change to OK.
void MakeTypicalPeerConnectionCall(const std::string& javascript) {
« no previous file with comments | « content/browser/browser_main_runner.cc ('k') | content/common/gpu/media/gpu_video_decode_accelerator.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698