Chromium Code Reviews
Help | Chromium Project | Sign in
(41)

Issue 3119033: Remove -rdynamic from the linux debug build. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 9 months ago by awong (On leave)
Modified:
4 years ago
Reviewers:
Evan Martin
CC:
chromium-reviews
Visibility:
Public.

Description

Remove -rdynamic from the linux debug build. Having -rdynamic breaks some plugins since it exports more symbols into the dynamic symbol table than wanted. In particular, this breaks users of ppapi's C++ wrappers. It was added to make StaceTraces resolve to symbols on linux. But now we use the symbolize library from glog so it isn't needed anymore. BUG=52105 TEST=Compiles and StackTrace.* test in base_unittests will work. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=56924

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -3 lines) Patch
M build/common.gypi View 1 chunk +0 lines, -3 lines 0 comments Download
Commit: CQ not working?

Messages

Total messages: 4 (0 generated)
awong (On leave)
Separating out this change since it's needed to fix ppapi.
4 years, 9 months ago (2010-08-20 20:17:31 UTC) #1
Evan Martin
On 2010/08/20 20:17:31, awong wrote: > Separating out this change since it's needed to fix ...
4 years, 9 months ago (2010-08-20 20:34:23 UTC) #2
awong (On leave)
Symbolize stuff.. The -rdynamic flag is only in the linux debug config. Doesn't affect mac ...
4 years, 9 months ago (2010-08-20 21:05:53 UTC) #3
Evan Martin
4 years, 9 months ago (2010-08-20 21:26:32 UTC) #4
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld ec887be