runtime/vm/cpuinfo_linux.cc - Issue 311903004: Fixes to run "Hello, world!" on arm64 hardware.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/cpuinfo_linux.cc

Issue 311903004: Fixes to run "Hello, world!" on arm64 hardware. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/cpuinfo_linux.cc

===================================================================

--- runtime/vm/cpuinfo_linux.cc (revision 36919)

+++ runtime/vm/cpuinfo_linux.cc (working copy)

@@ -28,15 +28,15 @@

fields_[kCpuInfoFeatures] = "flags";

method_ = kCpuInfoCpuId;

CpuId::InitOnce();

-#elif defined(HOST_ARCH_ARM)

+#elif defined(HOST_ARCH_ARM) || defined(HOST_ARCH_ARM64)

+ // TODO(zra): Verify that these field names are correct for arm64.

fields_[kCpuInfoProcessor] = "Processor";

fields_[kCpuInfoModel] = "model name";

fields_[kCpuInfoHardware] = "Hardware";

fields_[kCpuInfoFeatures] = "Features";

method_ = kCpuInfoSystem;

ProcCpuInfo::InitOnce();

-#elif defined(HOST_ARCH_MIPS) || defined(HOST_ARCH_ARM64)

-// TODO(zra): Verify that these field names are correct for arm64.

+#elif defined(HOST_ARCH_MIPS)

fields_[kCpuInfoProcessor] = "system type";

fields_[kCpuInfoModel] = "cpu model";

fields_[kCpuInfoHardware] = "cpu model";

« no previous file with comments | « runtime/vm/cpuinfo.h ('k') | runtime/vm/disassembler_arm64.cc » ('j') | no next file with comments »