Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(712)

Unified Diff: runtime/vm/assembler_arm64.cc

Issue 311903004: Fixes to run "Hello, world!" on arm64 hardware. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/assembler_arm64.h ('k') | runtime/vm/assembler_arm64_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/assembler_arm64.cc
===================================================================
--- runtime/vm/assembler_arm64.cc (revision 36919)
+++ runtime/vm/assembler_arm64.cc (working copy)
@@ -1081,9 +1081,7 @@
AddImmediate(SP, SP, -frame_space, kNoPP);
}
if (OS::ActivationFrameAlignment() > 1) {
- mov(TMP, SP); // SP can't be register operand of andi.
- andi(TMP, TMP, ~(OS::ActivationFrameAlignment() - 1));
- mov(SP, TMP);
+ andi(SP, SP, ~(OS::ActivationFrameAlignment() - 1));
}
}
@@ -1194,9 +1192,7 @@
for (int i = kDartFirstVolatileCpuReg; i <= kDartLastVolatileCpuReg; i++) {
const Register reg = static_cast<Register>(i);
- if ((reg != TMP) && (reg != TMP2)) {
- Push(reg);
- }
+ Push(reg);
}
ReserveAlignedFrameSpace(frame_size);
@@ -1207,16 +1203,13 @@
// SP might have been modified to reserve space for arguments
// and ensure proper alignment of the stack frame.
// We need to restore it before restoring registers.
- // TODO(zra): Also include FPU regs in this count once they are added.
const intptr_t kPushedRegistersSize =
kDartVolatileCpuRegCount * kWordSize +
kDartVolatileFpuRegCount * kWordSize;
AddImmediate(SP, FP, -kPushedRegistersSize, PP);
for (int i = kDartLastVolatileCpuReg; i >= kDartFirstVolatileCpuReg; i--) {
const Register reg = static_cast<Register>(i);
- if ((reg != TMP) && (reg != TMP2)) {
- Pop(reg);
- }
+ Pop(reg);
}
for (int i = 0; i < kNumberOfVRegisters; i++) {
« no previous file with comments | « runtime/vm/assembler_arm64.h ('k') | runtime/vm/assembler_arm64_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698