Remove dead notification for number of wheel event handlers

Remove dead notification for number of wheel event handlers

Turns out no-one needs this.

BUG=359566
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175659

[Sami, 2014-06-03 16:21:15]

PTAL. There are some vestiges of this on the Chromium side which can be removed
independently.

[eseidel, 2014-06-03 16:43:06]

lgtm

[eseidel, 2014-06-03 16:43:19]

Do we have any clue what this was originally for?

[Sami, 2014-06-03 16:43:29]

(try jobs failed since this depends on
https://codereview.chromium.org/225823007/)

[commit-bot: I haz the power, 2014-06-03 16:43:35]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/skyostil@chromium.org/311903002/1

[commit-bot: I haz the power, 2014-06-03 16:43:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-03 16:43:49]

Failed to apply patch for Source/core/frame/EventHandlerRegistry.cpp:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file Source/core/frame/EventHandlerRegistry.cpp
  Hunk #1 FAILED at 157.
  Hunk #2 FAILED at 165.
  2 out of 2 hunks FAILED -- saving rejects to file
Source/core/frame/EventHandlerRegistry.cpp.rej

Patch:       Source/core/frame/EventHandlerRegistry.cpp
Index: Source/core/frame/EventHandlerRegistry.cpp
diff --git a/Source/core/frame/EventHandlerRegistry.cpp
b/Source/core/frame/EventHandlerRegistry.cpp
index
3e3d38b5ae39a6dda1ec9f5e59da3fb9f7bd11b5..478ce65904bdb1af7e12f1fe21ad465f5021fc4b
100644
--- a/Source/core/frame/EventHandlerRegistry.cpp
+++ b/Source/core/frame/EventHandlerRegistry.cpp
@@ -157,7 +157,6 @@ void
EventHandlerRegistry::updateAllEventHandlers(ChangeOperation op, EventTarge
 void EventHandlerRegistry::notifyHasHandlersChanged(EventHandlerClass
handlerClass, bool hasActiveHandlers)
 {
     ScrollingCoordinator* scrollingCoordinator =
m_frameHost.page().scrollingCoordinator();
-    LocalFrame* mainFrame = m_frameHost.page().mainFrame();
 
     switch (handlerClass) {
     case ScrollEvent:
@@ -165,10 +164,6 @@ void
EventHandlerRegistry::notifyHasHandlersChanged(EventHandlerClass handlerCla
             scrollingCoordinator->updateHaveScrollEventHandlers();
         break;
     case WheelEvent:
-        if (mainFrame) {
-            // FIXME: This notification is wired up to a black hole, so remove
it.
-            mainFrame->notifyChromeClientWheelEventHandlerCountChanged();
-        }
         if (scrollingCoordinator)
             scrollingCoordinator->updateHaveWheelEventHandlers();
         break;

[Rick Byers, 2014-06-03 16:45:16]

Nice, LGTM - thanks!

It's probably worth mentioning in the CL description that we rely on the
WebLayer::setHaveWheelEventHandlers API to short-circuit sending wheel events to
blink.

[Sami, 2014-06-03 16:53:33]

Thanks!

On 2014/06/03 16:43:19, eseidel wrote:
> Do we have any clue what this was originally for?

Looks like this is part of back/forward swipe navigation on Mac but got never
hooked up: crbug.com/90228. +thakis@ who added this (and seems to be out at the
moment) and +rsesek@ who is some UI work for the same feature.

On 2014/06/03 16:45:16, Rick Byers wrote:
> Nice, LGTM - thanks!
> 
> It's probably worth mentioning in the CL description that we rely on the
> WebLayer::setHaveWheelEventHandlers API to short-circuit sending wheel events
to
> blink.

That feels unrelated, because that flag affects the compositor whereas this one
would hypothetically have changed event handling in the browser.

[Robert Sesek, 2014-06-03 17:48:34]

On 2014/06/03 16:53:33, Sami wrote:
> Thanks!
> 
> On 2014/06/03 16:43:19, eseidel wrote:
> > Do we have any clue what this was originally for?
> 
> Looks like this is part of back/forward swipe navigation on Mac but got never
> hooked up: crbug.com/90228. +thakis@ who added this (and seems to be out at
the
> moment) and +rsesek@ who is some UI work for the same feature.

Sorry, I'm not familiar with this piece of code. I did the browser-side UI and
Nico did a lot of the plumbing.

[Sami, 2014-06-03 17:52:00]

On 2014/06/03 17:48:34, rsesek wrote:
> Sorry, I'm not familiar with this piece of code. I did the browser-side UI and
> Nico did a lot of the plumbing.

Ok, thanks. Given that this particular bit hasn't been touched for 3 years I
think it's safe to remove it :)

[Nico, 2014-06-03 21:48:11]

erikchen has worked on mac history swiping most recently, but I agree that this
should be safe to remove.

[erikchen, 2014-06-03 21:52:15]

On 2014/06/03 21:48:11, Nico (traveling) wrote:
> erikchen has worked on mac history swiping most recently, but I agree that
this
> should be safe to remove.

Looks good to me.

[Sami, 2014-06-04 14:24:03]

The CQ bit was checked by skyostil@chromium.org

[commit-bot: I haz the power, 2014-06-04 14:24:11]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/skyostil@chromium.org/311903002/20001

[commit-bot: I haz the power, 2014-06-04 14:24:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-04 14:24:24]

Failed to apply patch for Source/core/loader/EmptyClients.h:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file Source/core/loader/EmptyClients.h
  Hunk #1 FAILED at 157.
  1 out of 1 hunk FAILED -- saving rejects to file
Source/core/loader/EmptyClients.h.rej

Patch:       Source/core/loader/EmptyClients.h
Index: Source/core/loader/EmptyClients.h
diff --git a/Source/core/loader/EmptyClients.h
b/Source/core/loader/EmptyClients.h
index
c99f775cb7f9dbe37d58e265f611337038059a17..642e65e2775cd2688f80322ee1f2bb7543f52d92
100644
--- a/Source/core/loader/EmptyClients.h
+++ b/Source/core/loader/EmptyClients.h
@@ -157,8 +157,6 @@ public:
     virtual void needTouchEvents(bool) OVERRIDE { }
     virtual void setTouchAction(TouchAction touchAction) OVERRIDE { };
 
-    virtual void numWheelEventHandlersChanged(unsigned) OVERRIDE { }
-
     virtual bool shouldRubberBandInDirection(WebCore::ScrollDirection) const
OVERRIDE { return false; }
 
     virtual void didAssociateFormControls(const
WillBeHeapVector<RefPtrWillBeMember<Element> >&) OVERRIDE { }

[Sami, 2014-06-04 15:56:53]

The CQ bit was checked by skyostil@chromium.org

[commit-bot: I haz the power, 2014-06-04 15:57:51]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/skyostil@chromium.org/311903002/40001

[commit-bot: I haz the power, 2014-06-04 17:51:42]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  blink_presubmit on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/6937)

[commit-bot: I haz the power, 2014-06-04 17:54:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-04 17:54:09]

Try jobs failed on following builders:
  blink_presubmit on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/6946)

[Sami, 2014-06-05 10:36:23]

The CQ bit was checked by skyostil@chromium.org

[commit-bot: I haz the power, 2014-06-05 10:37:01]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/skyostil@chromium.org/311903002/60001

[commit-bot: I haz the power, 2014-06-05 11:35:31]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  linux_blink_dbg on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/linux_blink_dbg/builds/1...)

[commit-bot: I haz the power, 2014-06-05 11:38:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-05 11:38:19]

Try jobs failed on following builders:
  linux_blink_dbg on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/linux_blink_dbg/builds/1...)

[Sami, 2014-06-06 09:59:48]

The CQ bit was checked by skyostil@chromium.org

[commit-bot: I haz the power, 2014-06-06 10:00:14]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/skyostil@chromium.org/311903002/80001

[commit-bot: I haz the power, 2014-06-06 11:17:50]

Change committed as 175659