Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2879)

Unified Diff: chrome/browser/chrome_elf_init_unittest_win.cc

Issue 311893005: Can now adjust the number of retries before the blacklist is disabled. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: <windows.h> is back Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/chrome_elf_init_win.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chrome_elf_init_unittest_win.cc
diff --git a/chrome/browser/chrome_elf_init_unittest_win.cc b/chrome/browser/chrome_elf_init_unittest_win.cc
index f98ee0817adce1a179da65ecee6fa9bd796184ed..c75edc05ace4d199d79babe415702142b1b4cf95 100644
--- a/chrome/browser/chrome_elf_init_unittest_win.cc
+++ b/chrome/browser/chrome_elf_init_unittest_win.cc
@@ -117,55 +117,29 @@ TEST_F(ChromeBlacklistTrialTest, VerifyFirstRun) {
ASSERT_EQ(version, GetBlacklistVersion());
}
-TEST_F(ChromeBlacklistTrialTest, SetupFailed) {
- // Set the registry to indicate that the blacklist setup is running,
- // which means it failed to run correctly last time for this version.
+TEST_F(ChromeBlacklistTrialTest, BlacklistFailed) {
+ // Ensure when the blacklist set up failed we set the state to disabled for
+ // future runs.
blacklist_registry_key_->WriteValue(blacklist::kBeaconVersion,
TEXT(CHROME_VERSION_STRING));
blacklist_registry_key_->WriteValue(blacklist::kBeaconState,
- blacklist::BLACKLIST_SETUP_RUNNING);
-
- BrowserBlacklistBeaconSetup();
-
- // Since the blacklist setup failed, it should now be disabled.
- ASSERT_EQ(blacklist::BLACKLIST_DISABLED, GetBlacklistState());
-}
-
-TEST_F(ChromeBlacklistTrialTest, ThunkSetupFailed) {
- // Set the registry to indicate that the blacklist thunk setup is running,
- // which means it failed to run correctly last time for this version.
- blacklist_registry_key_->WriteValue(blacklist::kBeaconVersion,
- TEXT(CHROME_VERSION_STRING));
- blacklist_registry_key_->WriteValue(blacklist::kBeaconState,
- blacklist::BLACKLIST_THUNK_SETUP);
-
- BrowserBlacklistBeaconSetup();
-
- // Since the blacklist thunk setup failed, it should now be disabled.
- ASSERT_EQ(blacklist::BLACKLIST_DISABLED, GetBlacklistState());
-}
-
-TEST_F(ChromeBlacklistTrialTest, InterceptionFailed) {
- // Set the registry to indicate that an interception is running,
- // which means it failed to run correctly last time for this version.
- blacklist_registry_key_->WriteValue(blacklist::kBeaconVersion,
- TEXT(CHROME_VERSION_STRING));
- blacklist_registry_key_->WriteValue(blacklist::kBeaconState,
- blacklist::BLACKLIST_INTERCEPTING);
+ blacklist::BLACKLIST_SETUP_FAILED);
BrowserBlacklistBeaconSetup();
- // Since an interception failed, the blacklist should now be disabled.
ASSERT_EQ(blacklist::BLACKLIST_DISABLED, GetBlacklistState());
}
TEST_F(ChromeBlacklistTrialTest, VersionChanged) {
- // Mark the blacklist as disabled for an older version, so it should
- // get enabled for this new version.
+ // Mark the blacklist as disabled for an older version, it should
+ // get enabled for this new version. Also record a non-zero number of
+ // setup failures, which should be reset to zero.
blacklist_registry_key_->WriteValue(blacklist::kBeaconVersion,
L"old_version");
blacklist_registry_key_->WriteValue(blacklist::kBeaconState,
blacklist::BLACKLIST_DISABLED);
+ blacklist_registry_key_->WriteValue(blacklist::kBeaconAttemptCount,
+ blacklist::kBeaconMaxAttempts);
BrowserBlacklistBeaconSetup();
@@ -175,6 +149,12 @@ TEST_F(ChromeBlacklistTrialTest, VersionChanged) {
chrome::VersionInfo version_info;
base::string16 expected_version(base::UTF8ToUTF16(version_info.Version()));
ASSERT_EQ(expected_version, GetBlacklistVersion());
+
+ // The counter should be reset.
+ DWORD attempt_count = blacklist::kBeaconMaxAttempts;
+ blacklist_registry_key_->ReadValueDW(blacklist::kBeaconAttemptCount,
+ &attempt_count);
+ ASSERT_EQ(static_cast<DWORD>(0), attempt_count);
}
TEST_F(ChromeBlacklistTrialTest, AddFinchBlacklistToRegistry) {
« no previous file with comments | « no previous file | chrome/browser/chrome_elf_init_win.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698