chrome_elf/chrome_elf_constants.cc - Issue 311893005: Can now adjust the number of retries before the blacklist is disabled.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome_elf/chrome_elf_constants.cc

Issue 311893005: Can now adjust the number of retries before the blacklist is disabled. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Corrected code so that it actually works as intended. Updated unit tests. Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome_elf/chrome_elf_constants.cc

diff --git a/chrome_elf/chrome_elf_constants.cc b/chrome_elf/chrome_elf_constants.cc

index 8879da7db83b80e430d2835c91695689864bc160..ebad138cc03c076d10ae1f7cb6a907b902d7e2cf 100644

--- a/chrome_elf/chrome_elf_constants.cc

+++ b/chrome_elf/chrome_elf_constants.cc

@@ -19,5 +19,8 @@ namespace blacklist {

const wchar_t kRegistryBeaconPath[] = L"SOFTWARE\\Google\\Chrome\\BLBeacon";

const wchar_t kBeaconVersion[] = L"version";

const wchar_t kBeaconState[] = L"state";

+const wchar_t kBeaconAttemptCount[] = L"failed_count";

+const DWORD kBeaconMaxAttempts = 2;

} // namespace blacklist

« chrome_elf/blacklist/test/blacklist_test.cc ('K') | « chrome_elf/chrome_elf_constants.h ('k') | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »