chrome/browser/chrome_elf_init_win.h - Issue 311893005: Can now adjust the number of retries before the blacklist is disabled.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chrome_elf_init_win.h

Issue 311893005: Can now adjust the number of retries before the blacklist is disabled. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Corrected code so that it actually works as intended. Updated unit tests. Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/chrome_elf_init_unittest_win.cc ('K') | « chrome/browser/chrome_elf_init_unittest_win.cc ('k') | chrome/browser/chrome_elf_init_win.cc » ('j') | chrome/browser/chrome_elf_init_win.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chrome_elf_init_win.h

diff --git a/chrome/browser/chrome_elf_init_win.h b/chrome/browser/chrome_elf_init_win.h

index d8787099a42b18125afaf2dd7f58bc914a81883e..48a42ec7a7bdb0b73d8bca22b4baef6a038a1957 100644

--- a/chrome/browser/chrome_elf_init_win.h

+++ b/chrome/browser/chrome_elf_init_win.h

@@ -5,6 +5,8 @@

#ifndef CHROME_BROWSER_CHROME_ELF_INIT_WIN_H_

#define CHROME_BROWSER_CHROME_ELF_INIT_WIN_H_

+#include <windows.h>

// Field trial name and full name for the blacklist disabled group.

extern const char kBrowserBlacklistTrialName[];

extern const char kBrowserBlacklistTrialDisabledGroupName[];

@@ -13,6 +15,11 @@ extern const char kBrowserBlacklistTrialDisabledGroupName[];

// only affect future runs since Chrome Elf is already setup by this point).

void InitializeChromeElf();

+// Helper function to grab from registry the number of times the startup has

csharp 2014/06/10 14:07:02 This function doesn't seem to exist anymore

krstnmnlsn 2014/06/10 22:03:26 Done.

+// failed before the blacklist was fully initialized. Will initialize the

+// registry value to zero if unfound.

+void GetBlacklistFailedCount(DWORD* failed_count);

// Set the required state for an enabled browser blacklist.

void BrowserBlacklistBeaconSetup();