Chromium Code Reviews Chromium Code Reviews
Issue 311893005:
Can now adjust the number of retries before the blacklist is disabled. (Closed)
Base URL: https://chromium.googlesource.com/chromium/src.git@master| Index: tools/metrics/histograms/histograms.xml |
| diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml |
| index f1b7b94458f2290bd5d1ede29790961a077c43e4..5237cce229070455ea87b8a99b1203f4a7144b4d 100644 |
| --- a/tools/metrics/histograms/histograms.xml |
| +++ b/tools/metrics/histograms/histograms.xml |
| @@ -1757,6 +1757,14 @@ Therefore, the affected-histogram name has to have at least one dot in it. |
| </summary> |
| </histogram> |
| +<histogram name="Blacklist.Disabled" enum="BooleanHit"> |
| + <owner>krstnmnlsn@chromium.org</owner> |
|
csharp
2014/06/05 14:55:01
Add me as an owner to the two new histograms as we
krstnmnlsn
2014/06/09 20:20:47
Done.
|
| + <summary> |
| + Counts the number of times the blacklist has been disabled (due to a failed |
| + set up). |
| + </summary> |
| +</histogram> |
| + |
| <histogram name="Blacklist.PatchedInRenderer" enum="BooleanHit"> |
| <owner>csharp@chromium.org</owner> |
| <summary> |
| @@ -1765,12 +1773,21 @@ Therefore, the affected-histogram name has to have at least one dot in it. |
| </summary> |
| </histogram> |
| +<histogram name="Blacklist.RetryWorked"> |
| + <owner>krstnmnlsn@chromium.org</owner> |
| + <summary> |
| + After a number of failing tries to set up the blacklist during start up we |
|
csharp
2014/06/05 14:55:01
This seems a bit wordy, maybe just say "Records th
krstnmnlsn
2014/06/09 20:20:47
Done.
|
| + disable it. If one of the retries works before this occurs, this records the |
| + try attempt we succeeded on. |
| + </summary> |
| +</histogram> |
| + |
| <histogram name="Blacklist.Setup" enum="BlacklistSetup"> |
| <owner>csharp@chromium.org</owner> |
| <summary> |
| Records the successes and failures when running the browser blacklist setup |
| code. Used to determine if the blacklist is working as intended during |
| - startup(since the blacklist runs before crash reporting is set up). This |
| + startup (since the blacklist runs before crash reporting is set up). This |
| only occurs on Windows. |
| </summary> |
| </histogram> |
