tools/metrics/histograms/histograms.xml - Issue 311893005: Can now adjust the number of retries before the blacklist is disabled.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/metrics/histograms/histograms.xml

Side-by-side diff isn't available for this file because of its large size.

Issue 311893005: Can now adjust the number of retries before the blacklist is disabled. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Merging in previous changes so that trybots can actually run hopefully. Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Download patch

Index: tools/metrics/histograms/histograms.xml

diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml

index 4a8a881c9070559e424cddffca7db974cb476c50..58d3d8011d7626d5f20bf1200edb6d1c05dc1e69 100644

--- a/tools/metrics/histograms/histograms.xml

+++ b/tools/metrics/histograms/histograms.xml

@@ -1765,12 +1765,21 @@ Therefore, the affected-histogram name has to have at least one dot in it.

</summary>

</histogram>

+<histogram name="Blacklist.RetryWorked">

jwd 2014/06/12 17:58:40 This name doesn't seem quite right. What about som

krstnmnlsn 2014/06/13 14:17:27 Done.

+ <owner>csharp@chromium.org</owner>

+ <owner>krstnmnlsn@chromium.org</owner>

+ <summary>

+ Records the number of attempts needed before the blacklist is properly

+ setup.

jwd 2014/06/12 18:18:30 Please mention when this is logged, eg: right afte

krstnmnlsn 2014/06/13 14:17:27 Done.

+ </summary>

+</histogram>

<owner>csharp@chromium.org</owner>

Records the successes and failures when running the browser blacklist setup

code. Used to determine if the blacklist is working as intended during

- startup(since the blacklist runs before crash reporting is set up). This

+ startup (since the blacklist runs before crash reporting is set up). This

jwd 2014/06/12 17:58:40 nit: remove double space ". This".

krstnmnlsn 2014/06/13 14:17:27 Done.

only occurs on Windows.

</summary>

</histogram>

« no previous file with comments | « chrome_elf/chrome_elf_constants.cc ('k') | no next file » | no next file with comments »