tools/metrics/histograms/histograms.xml - Issue 311893005: Can now adjust the number of retries before the blacklist is disabled.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/metrics/histograms/histograms.xml

Side-by-side diff isn't available for this file because of its large size.

Issue 311893005: Can now adjust the number of retries before the blacklist is disabled. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Adding setup failure counter, UMA recording and unit tests Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Download patch

Index: tools/metrics/histograms/histograms.xml

diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml

index f1b7b94458f2290bd5d1ede29790961a077c43e4..5237cce229070455ea87b8a99b1203f4a7144b4d 100644

--- a/tools/metrics/histograms/histograms.xml

+++ b/tools/metrics/histograms/histograms.xml

@@ -1757,6 +1757,14 @@ Therefore, the affected-histogram name has to have at least one dot in it.

</summary>

</histogram>

+<histogram name="Blacklist.Disabled" enum="BooleanHit">

+ <owner>krstnmnlsn@chromium.org</owner>

csharp 2014/06/05 14:55:01 Add me as an owner to the two new histograms as we

krstnmnlsn 2014/06/09 20:20:47 Done.

+ <summary>

+ Counts the number of times the blacklist has been disabled (due to a failed

+ set up).

+ </summary>

+</histogram>

<owner>csharp@chromium.org</owner>

@@ -1765,12 +1773,21 @@ Therefore, the affected-histogram name has to have at least one dot in it.

</summary>

</histogram>

+<histogram name="Blacklist.RetryWorked">

+ <owner>krstnmnlsn@chromium.org</owner>

+ <summary>

+ After a number of failing tries to set up the blacklist during start up we

csharp 2014/06/05 14:55:01 This seems a bit wordy, maybe just say "Records th

krstnmnlsn 2014/06/09 20:20:47 Done.

+ disable it. If one of the retries works before this occurs, this records the

+ try attempt we succeeded on.

+ </summary>

+</histogram>

<owner>csharp@chromium.org</owner>

Records the successes and failures when running the browser blacklist setup

code. Used to determine if the blacklist is working as intended during

- startup(since the blacklist runs before crash reporting is set up). This

+ startup (since the blacklist runs before crash reporting is set up). This

only occurs on Windows.

</summary>

</histogram>

« chrome/browser/chrome_elf_init_win.h ('K') | « chrome_elf/chrome_elf_constants.cc ('k') | no next file » | no next file with comments »