Can now adjust the number of retries before the blacklist is disabled.

chrome/browser/chrome_elf_init_unittest_win.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chrome_elf_init_win.h"
 
 #include "base/basictypes.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/metrics/field_trial.h"
 #include "base/strings/string16.h"
@@ skipping 95 matching lines @@
   BrowserBlacklistBeaconSetup();
 
   // Verify the state is properly set after the first run.
   ASSERT_EQ(blacklist::BLACKLIST_ENABLED, GetBlacklistState());
 
   chrome::VersionInfo version_info;
   base::string16 version(base::UTF8ToUTF16(version_info.Version()));
   ASSERT_EQ(version, GetBlacklistVersion());
 }
 
+// This test assumes that kBeaconAttemps (the number of startup retries we
+// allow) is at least 2.
 TEST_F(ChromeBlacklistTrialTest, SetupFailed) {
+  // Ensure the setup failure counter is low enough that even a new failure
+  // would leave the blacklist enabled.
+  blacklist_registry_key_->WriteValue(blacklist::kBeaconFailedCount,
+                                      kBeaconAttempts - 2);
+
   // Set the registry to indicate that the blacklist setup is running,
   // which means it failed to run correctly last time for this version.
   blacklist_registry_key_->WriteValue(blacklist::kBeaconVersion,
                                       TEXT(CHROME_VERSION_STRING));
   blacklist_registry_key_->WriteValue(blacklist::kBeaconState,
                                       blacklist::BLACKLIST_SETUP_RUNNING);
 
-   BrowserBlacklistBeaconSetup();
+  BrowserBlacklistBeaconSetup();
 
-  // Since the blacklist setup failed, it should now be disabled.
+  // The blacklist has now failed kBeaconAttempts - 1 times, the beacon should
+  // reflect this and the blacklist state be set to enabled.
+  DWORD failed_attempt_count = kBeaconAttempts;
+  GetBlacklistFailedCount(&failed_attempt_count);
+  ASSERT_EQ(kBeaconAttempts - 1, failed_attempt_count);
+  ASSERT_EQ(blacklist::BLACKLIST_ENABLED, GetBlacklistState());
+
+  // Force a second 'failure', this should disable the blacklist.
+  blacklist_registry_key_->WriteValue(blacklist::kBeaconVersion,
+                                      TEXT(CHROME_VERSION_STRING));
+  blacklist_registry_key_->WriteValue(blacklist::kBeaconState,
+                                      blacklist::BLACKLIST_SETUP_RUNNING);
+
+  BrowserBlacklistBeaconSetup();
   ASSERT_EQ(blacklist::BLACKLIST_DISABLED, GetBlacklistState());
 }
 
+TEST_F(ChromeBlacklistTrialTest, SetupSucceeded) {
+  // Write a non-zero value to the registry so that we can check it gets reset.
+  blacklist_registry_key_->WriteValue(blacklist::kBeaconFailedCount,
+                                      kBeaconAttempts);
+
+  blacklist_registry_key_->WriteValue(blacklist::kBeaconVersion,
+                                      TEXT(CHROME_VERSION_STRING));
+  blacklist_registry_key_->WriteValue(blacklist::kBeaconState,
+                                      blacklist::BLACKLIST_ENABLED);
+
+  BrowserBlacklistBeaconSetup();
+
+  // Because the set up was successful the counter should be reset.
+  DWORD attempt_count = kBeaconAttempts;
+  GetBlacklistFailedCount(&attempt_count);
+  ASSERT_EQ(static_cast<DWORD>(0), attempt_count);
+  ASSERT_EQ(blacklist::BLACKLIST_ENABLED, GetBlacklistState());
+}
+
 TEST_F(ChromeBlacklistTrialTest, ThunkSetupFailed) {
+  // Set the setup failure counter so that one more failure should disable the
+  // blacklist.
+  blacklist_registry_key_->WriteValue(blacklist::kBeaconFailedCount,
+                                      kBeaconAttempts - 1);
+
   // Set the registry to indicate that the blacklist thunk setup is running,
   // which means it failed to run correctly last time for this version.
   blacklist_registry_key_->WriteValue(blacklist::kBeaconVersion,
                                       TEXT(CHROME_VERSION_STRING));
   blacklist_registry_key_->WriteValue(blacklist::kBeaconState,
                                       blacklist::BLACKLIST_THUNK_SETUP);
 
   BrowserBlacklistBeaconSetup();
 
   // Since the blacklist thunk setup failed, it should now be disabled.
   ASSERT_EQ(blacklist::BLACKLIST_DISABLED, GetBlacklistState());
 }
 
 TEST_F(ChromeBlacklistTrialTest, InterceptionFailed) {
+  // Set the setup failure counter so that one more failure should disable the
+  // blacklist.
+  blacklist_registry_key_->WriteValue(blacklist::kBeaconFailedCount,
+                                      kBeaconAttempts - 1);
+
   // Set the registry to indicate that an interception is running,
   // which means it failed to run correctly last time for this version.
   blacklist_registry_key_->WriteValue(blacklist::kBeaconVersion,
                                       TEXT(CHROME_VERSION_STRING));
   blacklist_registry_key_->WriteValue(blacklist::kBeaconState,
                                       blacklist::BLACKLIST_INTERCEPTING);
 
   BrowserBlacklistBeaconSetup();
 
   // Since an interception failed, the blacklist should now be disabled.
   ASSERT_EQ(blacklist::BLACKLIST_DISABLED, GetBlacklistState());
 }
 
 TEST_F(ChromeBlacklistTrialTest, VersionChanged) {
   // Mark the blacklist as disabled for an older version, so it should
-  // get enabled for this new version.
+  // get enabled for this new version.  Also record a non-zero number of
+  // setup failures, this should be reset to zero.
   blacklist_registry_key_->WriteValue(blacklist::kBeaconVersion,
                                       L"old_version");
   blacklist_registry_key_->WriteValue(blacklist::kBeaconState,
                                       blacklist::BLACKLIST_DISABLED);
+  blacklist_registry_key_->WriteValue(blacklist::kBeaconFailedCount,
+                                      kBeaconAttempts);
 
   BrowserBlacklistBeaconSetup();
 
   // The beacon should now be marked as enabled for the current version.
   ASSERT_EQ(blacklist::BLACKLIST_ENABLED, GetBlacklistState());
 
   chrome::VersionInfo version_info;
   base::string16 expected_version(base::UTF8ToUTF16(version_info.Version()));
   ASSERT_EQ(expected_version, GetBlacklistVersion());
+
+  // The counter should be reset.
+  DWORD attempt_count = kBeaconAttempts;
+  GetBlacklistFailedCount(&attempt_count);
+  ASSERT_EQ(static_cast<DWORD>(0), attempt_count);
 }