Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(357)

Unified Diff: tools/gn/secondary/testing/BUILD.gn

Issue 311833004: GN: Remove dependency on //base for gmock. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Moved gmock_mutant to its own target Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/gn/secondary/testing/gmock/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/secondary/testing/BUILD.gn
diff --git a/tools/telemetry/telemetry/unittest/__init__.py b/tools/gn/secondary/testing/BUILD.gn
similarity index 59%
copy from tools/telemetry/telemetry/unittest/__init__.py
copy to tools/gn/secondary/testing/BUILD.gn
index 950282d0c11746826dd749cc1f0dafaf7d4780e9..2bda73c9f711315af2f9c253ec6d37c6777f7d54 100644
--- a/tools/telemetry/telemetry/unittest/__init__.py
+++ b/tools/gn/secondary/testing/BUILD.gn
@@ -1,3 +1,10 @@
# Copyright (c) 2014 The Chromium Authors. All rights reserved.
tfarina 2014/06/04 15:59:15 no (c) here.
kjellander_chromium 2014/06/04 16:44:33 Ah, I wasn't aware the (c) was deprecated. Fixed.
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
+
+static_library("gmock_mutant") {
tfarina 2014/06/04 15:59:15 I think we prefer source_set here instead.
kjellander_chromium 2014/06/04 16:44:33 Oh, of course!
+ sources = [
+ "gmock_mutant.h", # gMock helpers
+ ]
+ deps = [ "//base" ]
tfarina 2014/06/04 15:59:15 nit: I always put a blank line between sections fo
kjellander_chromium 2014/06/04 16:44:33 Done.
+}
« no previous file with comments | « no previous file | tools/gn/secondary/testing/gmock/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698