tools/gn/secondary/testing/BUILD.gn - Issue 311833004: GN: Remove dependency on //base for gmock.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: tools/gn/secondary/testing/BUILD.gn

Issue 311833004: GN: Remove dependency on //base for gmock. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Moved gmock_mutant to its own target Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 # Copyright (c) 2014 The Chromium Authors. All rights reserved.	1 # Copyright (c) 2014 The Chromium Authors. All rights reserved.
	tfarina 2014/06/04 15:59:15 no (c) here. no (c) here. kjellander_chromium 2014/06/04 16:44:33 Ah, I wasn't aware the (c) was deprecated. Fixed. Show quoted text On 2014/06/04 15:59:15, tfarina wrote: > no (c) here. Ah, I wasn't aware the (c) was deprecated. Fixed.
2 # Use of this source code is governed by a BSD-style license that can be	2 # Use of this source code is governed by a BSD-style license that can be

3 # found in the LICENSE file.	3 # found in the LICENSE file.

	4

	5 static_library("gmock_mutant") {
	tfarina 2014/06/04 15:59:15 I think we prefer source_set here instead. I think we prefer source_set here instead. kjellander_chromium 2014/06/04 16:44:33 Oh, of course! Show quoted text On 2014/06/04 15:59:15, tfarina wrote: > I think we prefer source_set here instead. Oh, of course!
	6 sources = [

	7 "gmock_mutant.h", # gMock helpers

	8 ]

	9 deps = [ "//base" ]
	tfarina 2014/06/04 15:59:15 nit: I always put a blank line between sections fo nit: I always put a blank line between sections for better readability (it just look nicer imo). kjellander_chromium 2014/06/04 16:44:33 Done. Show quoted text On 2014/06/04 15:59:15, tfarina wrote: > nit: I always put a blank line between sections for better readability (it just > look nicer imo). Done.
	10 }

OLD	NEW

« no previous file with comments | « no previous file | tools/gn/secondary/testing/gmock/BUILD.gn » ('j') | no next file with comments »