Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(453)

Unified Diff: Source/core/dom/Document.cpp

Issue 311803003: [oilpan]: Avoid refcounting QualifiedName's nullQName when tracing. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Review feedback Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/dom/Document.cpp
diff --git a/Source/core/dom/Document.cpp b/Source/core/dom/Document.cpp
index 02613ffb62168ff2fce5286458324ac3915ce6b6..e82751ace3fd7baa87055758e7a8f81f36696de7 100644
--- a/Source/core/dom/Document.cpp
+++ b/Source/core/dom/Document.cpp
@@ -777,12 +777,12 @@ static inline QualifiedName createQualifiedName(const AtomicString& namespaceURI
{
AtomicString prefix, localName;
if (!Document::parseQualifiedName(qualifiedName, prefix, localName, exceptionState))
- return nullQName();
+ return QualifiedName::null();
QualifiedName qName(prefix, localName, namespaceURI);
if (!Document::hasValidNamespaceForElements(qName)) {
exceptionState.throwDOMException(NamespaceError, "The namespace URI provided ('" + namespaceURI + "') is not valid for the qualified name provided ('" + qualifiedName + "').");
- return nullQName();
+ return QualifiedName::null();
}
return qName;
@@ -791,7 +791,7 @@ static inline QualifiedName createQualifiedName(const AtomicString& namespaceURI
PassRefPtrWillBeRawPtr<Element> Document::createElementNS(const AtomicString& namespaceURI, const AtomicString& qualifiedName, ExceptionState& exceptionState)
{
QualifiedName qName(createQualifiedName(namespaceURI, qualifiedName, exceptionState));
- if (qName == nullQName())
+ if (qName == QualifiedName::null())
return nullptr;
return createElement(qName, false);
@@ -800,7 +800,7 @@ PassRefPtrWillBeRawPtr<Element> Document::createElementNS(const AtomicString& na
PassRefPtrWillBeRawPtr<Element> Document::createElementNS(const AtomicString& namespaceURI, const AtomicString& qualifiedName, const AtomicString& typeExtension, ExceptionState& exceptionState)
{
QualifiedName qName(createQualifiedName(namespaceURI, qualifiedName, exceptionState));
- if (qName == nullQName())
+ if (qName == QualifiedName::null())
return nullptr;
RefPtrWillBeRawPtr<Element> element;

Powered by Google App Engine
This is Rietveld 408576698