Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Side by Side Diff: Source/core/animation/AnimationTimelineTest.cpp

Issue 311803003: [oilpan]: Avoid refcounting QualifiedName's nullQName when tracing. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Review feedback Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2013, Google Inc. All rights reserved. 2 * Copyright (c) 2013, Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 72 matching lines...) Expand 10 before | Expand all | Expand 10 after
83 AnimationTimeline::PlatformTiming::trace(visitor); 83 AnimationTimeline::PlatformTiming::trace(visitor);
84 } 84 }
85 }; 85 };
86 86
87 class AnimationAnimationTimelineTest : public ::testing::Test { 87 class AnimationAnimationTimelineTest : public ::testing::Test {
88 protected: 88 protected:
89 virtual void SetUp() 89 virtual void SetUp()
90 { 90 {
91 document = Document::create(); 91 document = Document::create();
92 document->animationClock().resetTimeForTesting(); 92 document->animationClock().resetTimeForTesting();
93 element = Element::create(nullQName() , document.get()); 93 element = Element::create(QualifiedName::null() , document.get());
94 platformTiming = new MockPlatformTiming; 94 platformTiming = new MockPlatformTiming;
95 timeline = AnimationTimeline::create(document.get(), adoptPtrWillBeNoop( platformTiming)); 95 timeline = AnimationTimeline::create(document.get(), adoptPtrWillBeNoop( platformTiming));
96 ASSERT_EQ(0, timeline->currentTimeInternal()); 96 ASSERT_EQ(0, timeline->currentTimeInternal());
97 } 97 }
98 98
99 virtual void TearDown() 99 virtual void TearDown()
100 { 100 {
101 document.release(); 101 document.release();
102 element.release(); 102 element.release();
103 timeline.release(); 103 timeline.release();
(...skipping 180 matching lines...) Expand 10 before | Expand all | Expand 10 after
284 284
285 TEST_F(AnimationAnimationTimelineTest, UseAnimationPlayerAfterTimelineDeref) 285 TEST_F(AnimationAnimationTimelineTest, UseAnimationPlayerAfterTimelineDeref)
286 { 286 {
287 RefPtrWillBeRawPtr<AnimationPlayer> player = timeline->createAnimationPlayer (0); 287 RefPtrWillBeRawPtr<AnimationPlayer> player = timeline->createAnimationPlayer (0);
288 timeline.clear(); 288 timeline.clear();
289 // Test passes if this does not crash. 289 // Test passes if this does not crash.
290 player->setStartTime(0); 290 player->setStartTime(0);
291 } 291 }
292 292
293 } 293 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698