Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(354)

Unified Diff: include/effects/SkDiscretePathEffect.h

Issue 311803002: Randomize seed for SkDiscretePathEffect::filterPath() (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Randomization depends on caller supplied seed and path length as discussed in skbug.com/2581 Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/effects/SkDiscretePathEffect.cpp » ('j') | src/effects/SkDiscretePathEffect.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: include/effects/SkDiscretePathEffect.h
diff --git a/include/effects/SkDiscretePathEffect.h b/include/effects/SkDiscretePathEffect.h
index 8373b6aa159ef4550380626dee3c56a46944c3b5..c048ca3cd99ee8f0293e107892e3e28c4ffb4e78 100644
--- a/include/effects/SkDiscretePathEffect.h
+++ b/include/effects/SkDiscretePathEffect.h
@@ -20,8 +20,11 @@ public:
away from the original path by a maximum of deviation.
Note: works on filled or framed paths
*/
- static SkDiscretePathEffect* Create(SkScalar segLength, SkScalar deviation) {
- return SkNEW_ARGS(SkDiscretePathEffect, (segLength, deviation));
+ static SkDiscretePathEffect* Create(SkScalar segLength,
+ SkScalar deviation,
+ uint32_t seedAssist=1) {
scroggo 2014/06/09 14:01:04 Please add a comment explaining what seedAssist do
rs.prinja 2014/06/11 04:15:16 Done.
+ return SkNEW_ARGS(SkDiscretePathEffect,
+ (segLength, deviation, seedAssist));
}
virtual bool filterPath(SkPath* dst, const SkPath& src,
@@ -30,13 +33,18 @@ public:
SK_DECLARE_PUBLIC_FLATTENABLE_DESERIALIZATION_PROCS(SkDiscretePathEffect)
protected:
- SkDiscretePathEffect(SkScalar segLength, SkScalar deviation);
+ SkDiscretePathEffect(SkScalar segLength,
+ SkScalar deviation,
+ uint32_t seedAssist);
explicit SkDiscretePathEffect(SkReadBuffer&);
virtual void flatten(SkWriteBuffer&) const SK_OVERRIDE;
private:
SkScalar fSegLength, fPerterb;
+ /* Caller-supplied 32 bit seed assist */
+ uint32_t fSeedAssist;
+
typedef SkPathEffect INHERITED;
};
« no previous file with comments | « no previous file | src/effects/SkDiscretePathEffect.cpp » ('j') | src/effects/SkDiscretePathEffect.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698