Issue 3118009: Reapplies r55735, fixing some message code that was checked in that I collided with.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 3118009: Reapplies r55735, fixing some message code that was checked in that I collided with. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
4 years, 9 months ago by Elliot Glaysher

Modified:
4 years ago

Reviewers:

CC:
chromium-reviews, jam, Paweł Hajdan Jr., ben+cc_chromium.org, darin-cc_chromium.org, brettw-cc_chromium.org

Base URL:
http://src.chromium.org/git/chromium.git

Visibility:
Public.

Reapplies r55735, fixing some message code that was checked in that I collided with. BUG=51411 TEST=none TBR=mpcomplete Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=55749

Created: 4 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+945 lines, -520 lines)			Patch
M	chrome/browser/renderer_host/resource_message_filter_win.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/chrome_common.gypi	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/common/render_messages.h	View	3 chunks	+8 lines, -51 lines	0 comments	Download
M	chrome/common/render_messages.cc	View	1 chunk	+63 lines, -0 lines	0 comments	Download
M	chrome/common/render_messages_unittest.cc	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/common/webkit_param_traits.h	View	3 chunks	+19 lines, -99 lines	0 comments	Download
A	chrome/common/webkit_param_traits.cc	View	1 chunk	+131 lines, -0 lines	0 comments	Download
M	chrome/renderer/render_view.cc	View	2 chunks	+2 lines, -0 lines	0 comments	Download
M	ipc/ipc_message_impl_macros.h	View	10 chunks	+486 lines, -116 lines	0 comments	Download
M	ipc/ipc_message_macros.h	View	35 chunks	+152 lines, -200 lines	0 comments	Download
M	ipc/ipc_message_utils.h	View	4 chunks	+63 lines, -54 lines	0 comments	Download
M	ipc/ipc_message_utils_impl.h	View	1 chunk	+13 lines, -0 lines	0 comments	Download
M	ipc/ipc_sync_channel_unittest.cc	View	1 chunk	+4 lines, -0 lines	0 comments	Download

Trybot results: win