Issue 3118002: List TLS_DHE_RSA_WITH_AES_256_CBC_SHA after...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 3118002: List TLS_DHE_RSA_WITH_AES_256_CBC_SHA after... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
4 years, 9 months ago by wtc

Modified:
4 years ago

Reviewers:
agl

CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

List TLS_DHE_RSA_WITH_AES_256_CBC_SHA after TLS_RSA_WITH_AES_256_CBC_SHA in ClientHello so that we communicate securely with some servers that use 256-bit DH keys. The proper fix is to upgrade to NSS 3.12.7 to pick up the DH key size checks. This is just a workaround. R=agl BUG=51694 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=55580

Patch Set 1 #

Patch Set 2 : Add Chromium issue number. #

Created: 4 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+68 lines, -2 lines)			Patch
M	net/third_party/nss/README.chromium	View	1	1 chunk	+8 lines, -0 lines	0 comments	Download
A	net/third_party/nss/patches/deprioritizedhe.patch	View		1 chunk	+58 lines, -0 lines	0 comments	Download
M	net/third_party/nss/ssl/ssl3con.c	View	1	2 chunks	+1 line, -1 line	0 comments	Download
M	net/third_party/nss/ssl/sslenum.c	View	1	2 chunks	+1 line, -1 line	0 comments	Download

Trybot results:

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages