Issue 311783005: Fix crash in NavigationControllerImpl::RendererDidNavigateToNewPage

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 311783005: Fix crash in NavigationControllerImpl::RendererDidNavigateToNewPage (Closed)

Created:
6 years, 6 months ago by Nate Chapin

Modified:
4 years, 9 months ago

Reviewers:
Avi (use Gerrit), nasko

CC:
chromium-reviews, darin-cc_chromium.org, nasko+codewatch_chromium.org, jam, creis+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Fix crash in NavigationControllerImpl::RendererDidNavigateToNewPage It's possible that the renderer does a same-document navigation before NavigationController has committed an entry, so null-check GetLastCommittedEntry before using it. BUG=380127 TEST=NavigationControllerTest.PushStateWithoutPreviousEntry Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274612

Patch Set 1 #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -1 line)			Patch
	M	content/browser/frame_host/navigation_controller_impl.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	content/browser/frame_host/navigation_controller_impl_unittest.cc	View		1 chunk	+13 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Nate Chapin

This adds a null-check that I missed in http://src.chromium.org/viewvc/chrome?view=revision&revision=274006

6 years, 6 months ago (2014-06-03 17:30:53 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/japhet@chromium.org/311783005/1

6 years, 6 months ago (2014-06-03 17:39:39 UTC) #4

Message was sent while issue was closed.

Change committed as 274612

Expand Messages | Collapse Messages