Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Issue 311783005: Fix crash in NavigationControllerImpl::RendererDidNavigateToNewPage (Closed)

Created:
6 years, 6 months ago by Nate Chapin
Modified:
4 years, 9 months ago
Reviewers:
Avi (use Gerrit), nasko
CC:
chromium-reviews, darin-cc_chromium.org, nasko+codewatch_chromium.org, jam, creis+watch_chromium.org
Visibility:
Public.

Description

Fix crash in NavigationControllerImpl::RendererDidNavigateToNewPage It's possible that the renderer does a same-document navigation before NavigationController has committed an entry, so null-check GetLastCommittedEntry before using it. BUG=380127 TEST=NavigationControllerTest.PushStateWithoutPreviousEntry Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274612

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -1 line) Patch
M content/browser/frame_host/navigation_controller_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/frame_host/navigation_controller_impl_unittest.cc View 1 chunk +13 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Nate Chapin
This adds a null-check that I missed in http://src.chromium.org/viewvc/chrome?view=revision&revision=274006
6 years, 6 months ago (2014-06-03 17:30:53 UTC) #1
nasko
lgtm
6 years, 6 months ago (2014-06-03 17:35:19 UTC) #2
Nate Chapin
The CQ bit was checked by japhet@chromium.org
6 years, 6 months ago (2014-06-03 17:38:11 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/japhet@chromium.org/311783005/1
6 years, 6 months ago (2014-06-03 17:39:39 UTC) #4
Avi (use Gerrit)
lgtm
6 years, 6 months ago (2014-06-03 17:45:40 UTC) #5
commit-bot: I haz the power
6 years, 6 months ago (2014-06-03 20:44:48 UTC) #6
Message was sent while issue was closed.
Change committed as 274612

Powered by Google App Engine
This is Rietveld 408576698