Source/modules/webmidi/MIDIController.h - Issue 311773003: Decouple MIDIAccess initialization from MIDIAccess class.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/webmidi/MIDIController.h

Issue 311773003: Decouple MIDIAccess initialization from MIDIAccess class. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/modules/webmidi/MIDIClient.h ('K') | « Source/modules/webmidi/MIDIClientMock.cpp ('k') | Source/modules/webmidi/MIDIController.cpp » ('j') | public/web/WebMIDIPermissionRequest.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/modules/webmidi/MIDIController.h

diff --git a/Source/modules/webmidi/MIDIController.h b/Source/modules/webmidi/MIDIController.h

index 5a93bd853403139eda52d640bcdde8514f9c5e33..f681737325b4c0a19738570889d1ed1f8cefbbd9 100644

--- a/Source/modules/webmidi/MIDIController.h

+++ b/Source/modules/webmidi/MIDIController.h

@@ -36,7 +36,7 @@

namespace WebCore {

-class MIDIAccess;

+class MIDIAccessInitializer;

class MIDIClient;

class MIDIController FINAL : public NoBaseWillBeGarbageCollectedFinalized<MIDIController>, public WillBeHeapSupplement<Page> {

@@ -44,8 +44,8 @@ class MIDIController FINAL : public NoBaseWillBeGarbageCollectedFinalized<MIDICo

public:

virtual ~MIDIController();

- void requestSysexPermission(PassRefPtrWillBeRawPtr<MIDIAccess>);

- void cancelSysexPermissionRequest(MIDIAccess*);

+ void requestSysexPermission(MIDIAccessInitializer*);

+ void cancelSysexPermissionRequest(MIDIAccessInitializer*);

static PassOwnPtrWillBeRawPtr<MIDIController> create(PassOwnPtr<MIDIClient>);

static const char* supplementName();

« Source/modules/webmidi/MIDIClient.h ('K') | « Source/modules/webmidi/MIDIClientMock.cpp ('k') | Source/modules/webmidi/MIDIController.cpp » ('j') | public/web/WebMIDIPermissionRequest.h » ('J')