Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(332)

Unified Diff: public/web/WebMIDIClient.h

Issue 311773003: Decouple MIDIAccess initialization from MIDIAccess class. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: rebase Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/web/WebMIDIPermissionRequest.cpp ('k') | public/web/WebMIDIPermissionRequest.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: public/web/WebMIDIClient.h
diff --git a/public/web/WebMIDIClient.h b/public/web/WebMIDIClient.h
index 86f39c10261236ca29ba6aeab52af47f512856c2..157c6be9db84302527b2eb986b9ca9baec8d14eb 100644
--- a/public/web/WebMIDIClient.h
+++ b/public/web/WebMIDIClient.h
@@ -38,10 +38,17 @@ class WebMIDIClient {
public:
virtual ~WebMIDIClient() { }
- // Request a permission to use system exclusive messages. Called when MIDIOptions.sysex is true.
- virtual void requestSysexPermission(const WebMIDIPermissionRequest&) = 0;
- // Cancel the request since the requesting frame may be moving to a new page.
- virtual void cancelSysexPermissionRequest(const WebMIDIPermissionRequest&) = 0;
+ // Request a permission to use system exclusive messages. Called when
+ // MIDIOptions.sysex is true.
+ // Once the request is done, any WebMIDIPermissionRequest instances equal to
+ // |request| must not be accessed after that.
+ virtual void requestSysexPermission(const WebMIDIPermissionRequest& /* request */) = 0;
+
+ // Cancel the request since the requesting frame may be moving to
+ // a new page.
+ // Once canceled, any WebMIDIPermissionRequest instances equal to
+ // |request| must not be accessed after that.
+ virtual void cancelSysexPermissionRequest(const WebMIDIPermissionRequest& /* request */) = 0;
};
} // namespace blink
« no previous file with comments | « Source/web/WebMIDIPermissionRequest.cpp ('k') | public/web/WebMIDIPermissionRequest.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698