Decouple MIDIAccess initialization from MIDIAccess class.

Source/modules/webmidi/MIDIAccess.h

 /*
  * Copyright (C) 2013 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 14 matching lines @@
  * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
  * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
  * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
 #ifndef MIDIAccess_h
 #define MIDIAccess_h
 
 #include "bindings/v8/ScriptPromise.h"
-#include "bindings/v8/ScriptPromiseResolverWithContext.h"
 #include "bindings/v8/ScriptWrappable.h"
 #include "core/dom/ActiveDOMObject.h"
 #include "modules/EventTargetModules.h"
 #include "modules/webmidi/MIDIAccessor.h"
 #include "modules/webmidi/MIDIAccessorClient.h"
 #include "modules/webmidi/MIDIInput.h"
-#include "modules/webmidi/MIDIOptions.h"
 #include "modules/webmidi/MIDIOutput.h"
 #include "platform/AsyncMethodRunner.h"
 #include "platform/heap/Handle.h"
 #include "wtf/RefCounted.h"
 #include "wtf/RefPtr.h"
 #include "wtf/WeakPtr.h"
 
 namespace WebCore {
 
 class ExecutionContext;
+class MIDIAccessInitializer;
+struct MIDIOptions;
 
 class MIDIAccess FINAL : public RefCountedWillBeRefCountedGarbageCollected<MIDIAccess>, public ScriptWrappable, public ActiveDOMObject, public EventTargetWithInlineData, public MIDIAccessorClient {
     REFCOUNTED_EVENT_TARGET(MIDIAccess);
     WILL_BE_USING_GARBAGE_COLLECTED_MIXIN(MIDIAccess);
 public:
     virtual ~MIDIAccess();
     // Returns a promise object that will be resolved with this MIDIAccess.
     static ScriptPromise request(const MIDIOptions&, ScriptState*);
 
     MIDIInputVector inputs() const { return m_inputs; }
     MIDIOutputVector outputs() const { return m_outputs; }
 
     DEFINE_ATTRIBUTE_EVENT_LISTENER(connect);
     DEFINE_ATTRIBUTE_EVENT_LISTENER(disconnect);
 
-    void setSysexEnabled(bool);
     bool sysexEnabled() const { return m_sysexEnabled; }
 
     // EventTarget
     virtual const AtomicString& interfaceName() const OVERRIDE { return EventTargetNames::MIDIAccess; }
     virtual ExecutionContext* executionContext() const OVERRIDE { return ActiveDOMObject::executionContext(); }
 
     // ActiveDOMObject
     virtual void stop() OVERRIDE;
     virtual bool hasPendingActivity() const OVERRIDE;
 
     // MIDIAccessorClient
     virtual void didAddInputPort(const String& id, const String& manufacturer, const String& name, const String& version) OVERRIDE;
     virtual void didAddOutputPort(const String& id, const String& manufacturer, const String& name, const String& version) OVERRIDE;

[Takashi Toyoshima, 2014/06/04 22:03:53]

We may want to have a comment here.
Why didStartSession() is not implemented here, e.g. IIUC,
MIDIAccessInitializer's implementation is called?

[kouhei (in TOK), 2014/06/05 01:19:44]

Can we have this as { ASSERT_NOT_REACHED(); }

[yhirano, 2014/06/05 11:35:25]

Done.

[yhirano, 2014/06/05 11:35:25]

Done.

-    virtual void didStartSession(bool success, const String& error, const String& message) OVERRIDE;
+    virtual void didStartSession(bool success, const String& error, const String& message) OVERRIDE { }
     virtual void didReceiveMIDIData(unsigned portIndex, const unsigned char* data, size_t length, double timeStamp) OVERRIDE;
 
     // |timeStampInMilliseconds| is in the same time coordinate system as performance.now().
     void sendMIDIData(unsigned portIndex, const unsigned char* data, size_t length, double timeStampInMilliseconds);
 
+    // Initialize this object before exposing it to JavaScript.
+    void initialize(PassOwnPtr<MIDIAccessor>, bool sysexEnabled);
+
     virtual void trace(Visitor*) OVERRIDE;
 
 private:
-    class PostAction;
-    enum State {
-        Requesting,
-        Resolved,
-        Stopped,
-    };
+    MIDIAccess(const MIDIOptions&, ExecutionContext*);
 
-    MIDIAccess(const MIDIOptions&, ExecutionContext*);
-    ScriptPromise startRequest(ScriptState*);
-
-    void permissionDenied();
-
-    // Called when the promise is resolved or rejected.
-    void doPostAction(State);
-
-    State m_state;
-    WeakPtrFactory<MIDIAccess> m_weakPtrFactory;
     MIDIInputVector m_inputs;
     MIDIOutputVector m_outputs;
     OwnPtr<MIDIAccessor> m_accessor;
-    MIDIOptions m_options;
     bool m_sysexEnabled;
-    RefPtr<ScriptPromiseResolverWithContext> m_resolver;
+
+    // FIXME: Stop owning initializer in this class.
+    OwnPtr<MIDIAccessInitializer> m_initializer;
 };
 
 } // namespace WebCore
 
 #endif // MIDIAccess_h