Issue 311753002: App Launcher: Preload the correct number of icons (don't assume 4x4).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 311753002: App Launcher: Preload the correct number of icons (don't assume 4x4). (Closed)

Created:
6 years, 6 months ago by Matt Giuca

Modified:
6 years, 6 months ago

Reviewers:
xiyuan

CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, tfarina, tapted

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

App Launcher: Preload the correct number of icons (don't assume 4x4). Previously, there would be a brief moment where the last two icons of the centered app list (--enable-centered-app-list) were not visible. Use the correct number of cols/rows instead of assuming 4x4. BUG=380015 TEST=With --enable-centered-app-list, click the app launcher button *immediately* after logging in. Should not be able to see missing icons (pay attention to the last two icons). Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274496

Patch Set 1 #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -6 lines)			Patch
	M	ui/app_list/views/app_list_main_view.cc	View		4 chunks	+9 lines, -4 lines	0 comments	Download
	M	ui/app_list/views/apps_grid_view.h	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mgiuca@chromium.org/311753002/20001

6 years, 6 months ago (2014-06-03 04:17:50 UTC) #4

Message was sent while issue was closed.

Change committed as 274496

Expand Messages | Collapse Messages