Source/modules/webmidi/NavigatorWebMIDI.cpp - Issue 311733004: Introduce KeepAliveWhilePending to ScriptPromiseResolverWithContext.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/webmidi/NavigatorWebMIDI.cpp

Issue 311733004: Introduce KeepAliveWhilePending to ScriptPromiseResolverWithContext. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@refactor-webmidi-initialization

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/modules/webmidi/NavigatorWebMIDI.cpp

diff --git a/Source/modules/webmidi/NavigatorWebMIDI.cpp b/Source/modules/webmidi/NavigatorWebMIDI.cpp

index 4e34e8fac98c57b06d9cd1a476c6c2c17696c59e..a0eee954dba3c42be5295fa67bd02b77b0ed1c93 100644

--- a/Source/modules/webmidi/NavigatorWebMIDI.cpp

+++ b/Source/modules/webmidi/NavigatorWebMIDI.cpp

@@ -33,11 +33,13 @@

#include "bindings/v8/ScriptPromise.h"

#include "bindings/v8/ScriptPromiseResolver.h"

+#include "core/dom/AsyncInitializerResolver.h"

#include "core/dom/DOMError.h"

#include "core/dom/Document.h"

#include "core/frame/LocalFrame.h"

#include "core/frame/Navigator.h"

#include "modules/webmidi/MIDIAccess.h"

+#include "modules/webmidi/MIDIAccessInitializer.h"

#include "modules/webmidi/MIDIOptions.h"

namespace WebCore {

@@ -81,7 +83,7 @@ ScriptPromise NavigatorWebMIDI::requestMIDIAccess(ScriptState* scriptState, cons

return promise;

}

- return MIDIAccess::request(MIDIOptions(options), scriptState);

+ return AsyncInitializerResolver<MIDIAccessInitializer>::createAndStart(scriptState, MIDIAccessInitializer::create(MIDIOptions(options)));

}

} // namespace WebCore

« Source/core/dom/AsyncInitializerResolver.h ('K') | « Source/modules/webmidi/MIDIAccessInitializer.cpp ('k') | no next file » | no next file with comments »