Introduce KeepAliveWhilePending to ScriptPromiseResolverWithContext.

Source/modules/crypto/CryptoResultImpl.h

Index: Source/modules/crypto/CryptoResultImpl.h
diff --git a/Source/modules/crypto/CryptoResultImpl.h b/Source/modules/crypto/CryptoResultImpl.h
index 0465969fe17e86c54995b7ca247752432e2f290c..88e59aacad070ba13d4827a23e6c1ec83612d247 100644
--- a/Source/modules/crypto/CryptoResultImpl.h
+++ b/Source/modules/crypto/CryptoResultImpl.h
@@ -31,49 +31,13 @@
 #ifndef CryptoResultImpl_h
 #define CryptoResultImpl_h
 
-#include "bindings/v8/ScriptPromise.h"
 #include "core/dom/ExceptionCode.h"
-#include "platform/CryptoResult.h"
 #include "public/platform/WebCrypto.h"
-#include "wtf/Forward.h"
-#include "wtf/WeakPtr.h"
 
 namespace WebCore {
 
 ExceptionCode webCryptoErrorToExceptionCode(blink::WebCryptoErrorType);

[eroman, 2014/06/13 01:52:52]

Since this file has been essentially renamed to CrossThreadCryptoResult, can you
move this last function out and delete it alltogether?

[yhirano, 2014/06/13 04:19:30]

Done.

 
-// Wrapper around a Promise to notify completion of the crypto operation.
-//
-// The thread on which CryptoResultImpl was created on is referred to as the
-// "origin thread".
-//
-//  * At creation time there must be an active ExecutionContext.
-//  * The CryptoResult interface must only be called from the origin thread.
-//  * addref() and deref() can be called from any thread.
-//  * One of the completeWith***() functions must be called, or the
-//    PromiseState will be leaked until the ExecutionContext is destroyed.
-class CryptoResultImpl FINAL : public CryptoResult {
-public:
-    ~CryptoResultImpl();
-
-    static PassRefPtr<CryptoResultImpl> create(ScriptState*);
-
-    virtual void completeWithError(blink::WebCryptoErrorType, const blink::WebString&) OVERRIDE;
-    virtual void completeWithBuffer(const blink::WebArrayBuffer&) OVERRIDE;
-    virtual void completeWithBoolean(bool) OVERRIDE;
-    virtual void completeWithKey(const blink::WebCryptoKey&) OVERRIDE;
-    virtual void completeWithKeyPair(const blink::WebCryptoKey& publicKey, const blink::WebCryptoKey& privateKey) OVERRIDE;
-
-    // It is only valid to call this before completion.
-    ScriptPromise promise();
-
-private:
-    explicit CryptoResultImpl(ScriptState*);
-
-    class PromiseState;
-    WeakPtr<PromiseState> m_promiseState;
-};
-
 } // namespace WebCore
 
 #endif