Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1318)

Unified Diff: Source/modules/crypto/CryptoResultImpl.cpp

Issue 311733004: Introduce KeepAliveWhilePending to ScriptPromiseResolverWithContext. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@refactor-webmidi-initialization
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/modules/crypto/CryptoResultImpl.cpp
diff --git a/Source/modules/crypto/CryptoResultImpl.cpp b/Source/modules/crypto/CryptoResultImpl.cpp
index 3870fa7f9f5ac5597718894e163be1e004990d13..6181756b639eeaf1b7f14fa5fbfbd4126c9aea58 100644
--- a/Source/modules/crypto/CryptoResultImpl.cpp
+++ b/Source/modules/crypto/CryptoResultImpl.cpp
@@ -31,19 +31,8 @@
#include "config.h"
#include "modules/crypto/CryptoResultImpl.h"
-#include "bindings/v8/ScriptPromiseResolverWithContext.h"
-#include "bindings/v8/ScriptState.h"
-#include "core/dom/ContextLifecycleObserver.h"
-#include "core/dom/DOMError.h"
#include "core/dom/DOMException.h"
-#include "core/dom/ExecutionContext.h"
-#include "modules/crypto/Key.h"
-#include "modules/crypto/KeyPair.h"
-#include "modules/crypto/NormalizeAlgorithm.h"
-#include "public/platform/Platform.h"
-#include "public/platform/WebArrayBuffer.h"
-#include "public/platform/WebCryptoAlgorithm.h"
-#include "wtf/ArrayBufferView.h"
+#include "public/platform/WebCrypto.h"
namespace WebCore {
@@ -75,149 +64,4 @@ ExceptionCode webCryptoErrorToExceptionCode(blink::WebCryptoErrorType errorType)
return 0;
}
-// The PromiseState class contains all the state which is tied to an
-// ExecutionContext. Whereas CryptoResultImpl can be deleted from any thread,
-// PromiseState is not thread safe and must only be accessed and deleted from
-// the blink thread.
-//
-// This is achieved by making CryptoResultImpl hold a WeakPtr to the PromiseState.
-// The PromiseState deletes itself after being notified of completion.
-// Additionally the PromiseState is deleted when the ExecutionContext is
-// destroyed (necessary to avoid leaks when dealing with WebWorker threads,
-// which may die before the operation is completed).
-class CryptoResultImpl::PromiseState FINAL {
-public:
- static WeakPtr<PromiseState> create(ScriptState* scriptState)
- {
- PromiseState* promiseState = new PromiseState(scriptState);
- return promiseState->m_weakFactory.createWeakPtr();
- }
-
- void contextDestroyed()
- {
- delete this;
- }
-
- ScriptPromise promise()
- {
- return m_promiseResolver->promise();
- }
-
- void completeWithError(blink::WebCryptoErrorType errorType, const blink::WebString& errorDetails)
- {
- m_promiseResolver->reject(DOMException::create(webCryptoErrorToExceptionCode(errorType), errorDetails));
- delete this;
- }
-
- void completeWithBuffer(const blink::WebArrayBuffer& buffer)
- {
- m_promiseResolver->resolve(PassRefPtr<ArrayBuffer>(buffer));
- delete this;
- }
-
- void completeWithBoolean(bool b)
- {
- m_promiseResolver->resolve(b);
- delete this;
- }
-
- void completeWithKey(const blink::WebCryptoKey& key)
- {
- m_promiseResolver->resolve(Key::create(key));
- delete this;
- }
-
- void completeWithKeyPair(const blink::WebCryptoKey& publicKey, const blink::WebCryptoKey& privateKey)
- {
- m_promiseResolver->resolve(KeyPair::create(publicKey, privateKey));
- delete this;
- }
-
-private:
- // This subclass of ScriptPromiseResolverWithContext is to be notified
- // when the context was destroyed.
- class PromiseResolver FINAL : public ScriptPromiseResolverWithContext {
- public:
- static PassRefPtr<PromiseResolver> create(ScriptState* scriptState, PromiseState* promiseState)
- {
- RefPtr<PromiseResolver> resolver = adoptRef(new PromiseResolver(scriptState, promiseState));
- resolver->suspendIfNeeded();
- return resolver.release();
- }
-
- virtual void contextDestroyed() OVERRIDE
- {
- ScriptPromiseResolverWithContext::contextDestroyed();
- m_promiseState->contextDestroyed();
- }
-
- private:
- explicit PromiseResolver(ScriptState* scriptState, PromiseState* promiseState)
- : ScriptPromiseResolverWithContext(scriptState)
- , m_promiseState(promiseState)
- {
- }
-
- PromiseState* m_promiseState;
- };
-
- explicit PromiseState(ScriptState* scriptState)
- : m_weakFactory(this)
- , m_promiseResolver(PromiseResolver::create(scriptState, this))
- {
- }
-
- WeakPtrFactory<PromiseState> m_weakFactory;
- RefPtr<PromiseResolver> m_promiseResolver;
-};
-
-CryptoResultImpl::~CryptoResultImpl()
-{
-}
-
-PassRefPtr<CryptoResultImpl> CryptoResultImpl::create(ScriptState* scriptState)
-{
- return adoptRef(new CryptoResultImpl(scriptState));
-}
-
-void CryptoResultImpl::completeWithError(blink::WebCryptoErrorType errorType, const blink::WebString& errorDetails)
-{
- if (m_promiseState)
- m_promiseState->completeWithError(errorType, errorDetails);
-}
-
-void CryptoResultImpl::completeWithBuffer(const blink::WebArrayBuffer& buffer)
-{
- if (m_promiseState)
- m_promiseState->completeWithBuffer(buffer);
-}
-
-void CryptoResultImpl::completeWithBoolean(bool b)
-{
- if (m_promiseState)
- m_promiseState->completeWithBoolean(b);
-}
-
-void CryptoResultImpl::completeWithKey(const blink::WebCryptoKey& key)
-{
- if (m_promiseState)
- m_promiseState->completeWithKey(key);
-}
-
-void CryptoResultImpl::completeWithKeyPair(const blink::WebCryptoKey& publicKey, const blink::WebCryptoKey& privateKey)
-{
- if (m_promiseState)
- m_promiseState->completeWithKeyPair(publicKey, privateKey);
-}
-
-CryptoResultImpl::CryptoResultImpl(ScriptState* scriptState)
- : m_promiseState(PromiseState::create(scriptState))
-{
-}
-
-ScriptPromise CryptoResultImpl::promise()
-{
- return m_promiseState->promise();
-}
-
} // namespace WebCore

Powered by Google App Engine
This is Rietveld 408576698