Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Issue 311733003: Fix ExceptionState with empty context. (Closed)

Created:
6 years, 6 months ago by tasak
Modified:
6 years, 6 months ago
Reviewers:
haraken
CC:
blink-reviews, blink-reviews-bindings_chromium.org, dglazkov+blink, dominicc+watchlist_chromium.org, arv+blink, abarth-chromium
Visibility:
Public.

Description

Fix ExceptionState with empty context. Since NonThrowableExceptionState, TrackExceptionState, NoExceptionStateAssertionChecker and IgnorableExceptionState create no wrapper, we don't need to fix those exception state with empty context. We need to fix ExceptionState. To ensure that all ExceptionStates are fixed, added ASSERT to ExceptionState::throwSecurityError and ExceptionState::throwDOMException. BUG=369451 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175463

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M Source/bindings/v8/ExceptionState.cpp View 2 chunks +2 lines, -0 lines 0 comments Download
M Source/bindings/v8/V8Initializer.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (0 generated)
tasak
6 years, 6 months ago (2014-06-03 09:32:24 UTC) #1
tasak
Would you review this CL?
6 years, 6 months ago (2014-06-03 11:57:48 UTC) #2
haraken
LGTM, assuming that you've confirmed that all call sites of ExceptionState pass in a creation ...
6 years, 6 months ago (2014-06-03 12:13:55 UTC) #3
tasak
The CQ bit was checked by tasak@google.com
6 years, 6 months ago (2014-06-04 03:33:44 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tasak@google.com/311733003/30001
6 years, 6 months ago (2014-06-04 03:34:04 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_blink_rel on tryserver.blink ...
6 years, 6 months ago (2014-06-04 03:51:10 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-04 04:06:24 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/10679)
6 years, 6 months ago (2014-06-04 04:06:25 UTC) #8
tasak
The CQ bit was checked by tasak@google.com
6 years, 6 months ago (2014-06-04 09:14:32 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tasak@google.com/311733003/30001
6 years, 6 months ago (2014-06-04 09:14:51 UTC) #10
commit-bot: I haz the power
6 years, 6 months ago (2014-06-04 09:39:26 UTC) #11
Message was sent while issue was closed.
Change committed as 175463

Powered by Google App Engine
This is Rietveld 408576698