Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Issue 311673002: updated w3c import script to align with the new css test repo structure (Closed)

Created:
6 years, 6 months ago by rhauck
Modified:
6 years, 4 months ago
Reviewers:
Dirk Pranke
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

updated w3c import script to align with the new css test repo structure as described here: http://lists.w3.org/Archives/Public/public-css-testsuite/2014May/0000.html Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180118

Patch Set 1 #

Total comments: 1

Patch Set 2 : updating test importer to reflect new csswg repo structure #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -29 lines) Patch
M Tools/Scripts/webkitpy/w3c/test_importer.py View 1 6 chunks +2 lines, -29 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
Dirk Pranke
The changes to w3c_importer.py lgtm (assuming my comment is correct). We should separate that change ...
6 years, 4 months ago (2014-08-12 00:50:23 UTC) #1
rhauck
On 2014/08/12 00:50:23, Dirk Pranke wrote: > The changes to w3c_importer.py lgtm (assuming my comment ...
6 years, 4 months ago (2014-08-12 20:21:09 UTC) #2
rhauck
The CQ bit was checked by rhauck@adobe.com
6 years, 4 months ago (2014-08-12 20:21:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rhauck@adobe.com/311673002/20001
6 years, 4 months ago (2014-08-12 20:21:42 UTC) #4
Dirk Pranke
The CQ bit was unchecked by dpranke@chromium.org
6 years, 4 months ago (2014-08-12 20:26:22 UTC) #5
Dirk Pranke
On 2014/08/12 20:21:42, I haz the power (commit-bot) wrote: > CQ is trying da patch. ...
6 years, 4 months ago (2014-08-12 20:27:01 UTC) #6
rhauck
On 2014/08/12 20:27:01, Dirk Pranke wrote: > On 2014/08/12 20:21:42, I haz the power (commit-bot) ...
6 years, 4 months ago (2014-08-12 20:32:57 UTC) #7
Dirk Pranke
On 2014/08/12 20:32:57, rhauck wrote: > On 2014/08/12 20:27:01, Dirk Pranke wrote: > > On ...
6 years, 4 months ago (2014-08-12 20:36:32 UTC) #8
rhauck
The CQ bit was checked by rhauck@adobe.com
6 years, 4 months ago (2014-08-12 20:54:13 UTC) #9
rhauck
The CQ bit was unchecked by rhauck@adobe.com
6 years, 4 months ago (2014-08-12 20:54:18 UTC) #10
rhauck
The CQ bit was checked by rhauck@adobe.com
6 years, 4 months ago (2014-08-12 20:54:39 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rhauck@adobe.com/311673002/20001
6 years, 4 months ago (2014-08-12 20:56:42 UTC) #12
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_rel on tryserver.blink ...
6 years, 4 months ago (2014-08-12 22:03:31 UTC) #13
commit-bot: I haz the power
6 years, 4 months ago (2014-08-12 23:17:31 UTC) #14
Message was sent while issue was closed.
Change committed as 180118

Powered by Google App Engine
This is Rietveld 408576698