Extract analysis/notifications into a separate operation/file.

pkg/analysis_server/test/reflective_tests.dart

Index: pkg/analysis_server/test/reflective_tests.dart
diff --git a/pkg/analysis_server/test/reflective_tests.dart b/pkg/analysis_server/test/reflective_tests.dart
new file mode 100644
index 0000000000000000000000000000000000000000..107812e75f805b10f13c56627cf6e52f4b0cbb19
--- /dev/null
+++ b/pkg/analysis_server/test/reflective_tests.dart
@@ -0,0 +1,74 @@
+// Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
+// for details. All rights reserved. Use of this source code is governed by a
+// BSD-style license that can be found in the LICENSE file.
+
+library reflective.tests;

[Brian Wilkerson, 2014/06/02 20:12:58]

Do we really need another test framework? I'm not sure I understand what this
one buys us.

+
+import 'dart:async';
+
+@MirrorsUsed(metaTargets: 'ReflectiveTestCase')
+import 'dart:mirrors';
+
+import 'package:unittest/unittest.dart';
+
+
+/**
+ * A marker annotation used to instruct dart2js to keep reflection information
+ * for the annotated classes.
+ */
+class ReflectiveTestCase {
+  const ReflectiveTestCase();
+}
+
+
+/**
+ * Runs test methods existing in the given [type].
+ *
+ * Methods with names starting with `test` are run using [test] function.
+ * Methods with names starting with `solo_test` are run using [solo_test] function.
+ *
+ * Each method is run with a new instance of [type].
+ * So, [type] should have a default constructor.
+ *
+ * If [type] declares method `setUp`, it methods will be invoked before any test
+ * method invocation.
+ *
+ * If [type] declares method `tearDown`, it will be invoked after any test
+ * method invocation. If method returns [Future] to test some asyncronous
+ * behavior, then `tearDown` will be invoked in `Future.complete`.
+ */
+void runReflectiveTests(Type type) {

[Paul Berry, 2014/06/02 20:07:34]

I thought we decided that we were going to move away from the Java-style
reflective tests and follow the recommendations of
https://www.dartlang.org/articles/dart-unit-tests/.  Was there further
discussion about this that I missed?

[scheglov, 2014/06/02 20:38:09]

I have been trying different approaches to write tests for
notification.navigation and with helper code looks like shit.
With all these constant repetitions of helper. helper. helper. everywhere.
Also I cannot navigate in these tests.
And I'd like to sort them automatically, which is more-less doable to methods,
but not so easy for test()/group() invocations.


We still use unit-test package, but with a layer on top of it.

+  ClassMirror classMirror = reflectClass(type);
+  classMirror.instanceMembers.forEach((symbol, memberMirror) {
+    // we need only methods
+    if (memberMirror is! MethodMirror || !memberMirror.isRegularMethod) {
+      return;
+    }
+    // check name
+    String memberName = MirrorSystem.getName(symbol);
+    if (memberName.startsWith('test_')) {
+      String testName = memberName.substring('test_'.length);
+      test(testName, () {
+        InstanceMirror instanceMirror = classMirror.newInstance(new Symbol(''), []);
+        _invokeSymbolIfExists(instanceMirror, #setUp);
+        var testReturn = instanceMirror.invoke(symbol, []).reflectee;
+        if (testReturn is Future) {
+          return testReturn.whenComplete(() {
+            _invokeSymbolIfExists(instanceMirror, #tearDown);
+          });
+        } else {
+          _invokeSymbolIfExists(instanceMirror, #tearDown);
+          return testReturn;
+        }
+      });
+    }
+  });
+}
+
+
+void _invokeSymbolIfExists(InstanceMirror instanceMirror, Symbol symbol) {
+  try {
+    instanceMirror.invoke(symbol, []);
+  } on NoSuchMethodError catch (e) {
+  }
+}