Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1140)

Issue 311643002: Revert 274278 "Generate java bindings for constants." (Closed)

Created:
6 years, 6 months ago by Lambros
Modified:
6 years, 6 months ago
Reviewers:
qsr
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 274278 "Generate java bindings for constants." Reverting as we think it caused checkdeps failure on Linux: http://build.chromium.org/p/chromium.linux/builders/Linux%20Builder%20%28dbg%29%2832%29/builds/24742/steps/checkdeps/logs/stdio ERROR in /b/build/slave/Linux_Builder__dbg__32_/build/src/mojo/android/javatests/src/org/chromium/mojo/bindings/BindingsTest.java Illegal include: "out/Debug/java_mojo/mojo_public_test_interfaces/src/org/chromium/mojo/bindings/test/sample/SampleServiceConstants.java" Because of no rule applying. > Generate java bindings for constants. > > This CL is the first CL introducing java bindings. It only generates constants. > > This is a reland of https://codereview.chromium.org/291903003 > > TBR=viettrungluu@chromium.org,rmcilroy@chromium.org > > Review URL: https://codereview.chromium.org/305963009 TBR=qsr@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274296

Patch Set 1 #

Messages

Total messages: 3 (0 generated)
Lambros
6 years, 6 months ago (2014-06-02 19:12:47 UTC) #1
Lambros
Committed patchset #1 manually as r274296 (tree was closed).
6 years, 6 months ago (2014-06-02 19:13:04 UTC) #2
qsr
6 years, 6 months ago (2014-06-03 09:49:41 UTC) #3
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698