Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(264)

Issue 311633002: Pull up LayoutStateDisabler in updateFirstLetterStyle (Closed)

Created:
6 years, 6 months ago by leviw_travelin_and_unemployed
Modified:
6 years, 6 months ago
CC:
blink-reviews, blink-reviews-rendering, zoltan1, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, pdr., rune+blink
Visibility:
Public.

Description

Pull up LayoutStateDisabler in updateFirstLetterStyle Avoid improper repainting/asserting when falling into the case in updateFirstLetterStyle where the style change doesn't trigger a reattach. In that case, we'd still potentially issue a repaint, but without the LayoutStateDisabler, and with LayoutState set up improperly for the task. BUG=379802 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175319

Patch Set 1 #

Total comments: 1

Patch Set 2 : Rename to layoutStateDisabler #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -1 line) Patch
A LayoutTests/fast/css/first-letter-stylechange-isnt-reattach-assert.html View 1 chunk +14 lines, -0 lines 0 comments Download
A LayoutTests/fast/css/first-letter-stylechange-isnt-reattach-assert-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/rendering/RenderBlock.cpp View 1 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
leviw_travelin_and_unemployed
PTAL
6 years, 6 months ago (2014-06-02 18:47:37 UTC) #1
dsinclair
lgtm https://codereview.chromium.org/311633002/diff/1/Source/core/rendering/RenderBlock.cpp File Source/core/rendering/RenderBlock.cpp (right): https://codereview.chromium.org/311633002/diff/1/Source/core/rendering/RenderBlock.cpp#newcode3989 Source/core/rendering/RenderBlock.cpp:3989: LayoutStateDisabler disabler(*this); nit: s/disabler/layoutStateDisabler I've run into this ...
6 years, 6 months ago (2014-06-02 19:12:53 UTC) #2
leviw_travelin_and_unemployed
On 2014/06/02 19:12:53, dsinclair wrote: > lgtm > > https://codereview.chromium.org/311633002/diff/1/Source/core/rendering/RenderBlock.cpp > File Source/core/rendering/RenderBlock.cpp (right): > ...
6 years, 6 months ago (2014-06-02 19:32:03 UTC) #3
leviw_travelin_and_unemployed
The CQ bit was checked by leviw@chromium.org
6 years, 6 months ago (2014-06-02 19:32:16 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/leviw@chromium.org/311633002/20001
6 years, 6 months ago (2014-06-02 19:33:05 UTC) #5
commit-bot: I haz the power
6 years, 6 months ago (2014-06-02 21:42:04 UTC) #6
Message was sent while issue was closed.
Change committed as 175319

Powered by Google App Engine
This is Rietveld 408576698