Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Issue 311613002: Add error log in case enrolled device lacks DM token. (Closed)

Created:
6 years, 6 months ago by Thiemo Nagel
Modified:
6 years, 6 months ago
Reviewers:
pastarmovj
CC:
chromium-reviews, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Add error log in case enrolled device lacks DM token. BUG=379875 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274375

Patch Set 1 #

Total comments: 2

Patch Set 2 : Use LOG_IF(). #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M chrome/browser/chromeos/policy/device_cloud_policy_store_chromeos.cc View 1 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Thiemo Nagel
Hi Julian, could you please take a look add this CL? Do you think we ...
6 years, 6 months ago (2014-06-02 15:27:12 UTC) #1
pastarmovj
LGTM with a nit. I think this level of logging is fine for now. On ...
6 years, 6 months ago (2014-06-02 15:35:53 UTC) #2
Thiemo Nagel
Thank you!
6 years, 6 months ago (2014-06-02 19:35:31 UTC) #3
Thiemo Nagel
https://codereview.chromium.org/311613002/diff/1/chrome/browser/chromeos/policy/device_cloud_policy_store_chromeos.cc File chrome/browser/chromeos/policy/device_cloud_policy_store_chromeos.cc (right): https://codereview.chromium.org/311613002/diff/1/chrome/browser/chromeos/policy/device_cloud_policy_store_chromeos.cc#newcode153 chrome/browser/chromeos/policy/device_cloud_policy_store_chromeos.cc:153: << "Status: " << status << "."; On 2014/06/02 ...
6 years, 6 months ago (2014-06-02 19:40:50 UTC) #4
Thiemo Nagel
The CQ bit was checked by tnagel@chromium.org
6 years, 6 months ago (2014-06-02 19:41:08 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tnagel@chromium.org/311613002/20001
6 years, 6 months ago (2014-06-02 19:41:48 UTC) #6
commit-bot: I haz the power
6 years, 6 months ago (2014-06-02 23:52:37 UTC) #7
Message was sent while issue was closed.
Change committed as 274375

Powered by Google App Engine
This is Rietveld 408576698