Reenable optimization on XMLHttpRequest's receive-as-blob functionality

Reenable optimization on XMLHttpRequest's receive-as-blob functionality

Due to a bug in RedirectToFile functionality of Chromium, the
optimization CL was reverted
(http://src.chromium.org/viewvc/blink?view=revision&revision=168993).

This CL reenables the optimization as
https://codereview.chromium.org/82273002/ fixed the bugs.

BUG=347663
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175446

[Nate Chapin, 2014-06-02 16:59:50]

LGTM, just a couple of questions.

https://codereview.chromium.org/311593002/diff/40001/Source/core/xml/XMLHttpR...
File Source/core/xml/XMLHttpRequest.cpp (right):

https://codereview.chromium.org/311593002/diff/40001/Source/core/xml/XMLHttpR...
Source/core/xml/XMLHttpRequest.cpp:859: if (responseTypeCode() ==
ResponseTypeBlob)
Can we combine the two blob cases in this function, just to keep them together?

https://codereview.chromium.org/311593002/diff/40001/Source/core/xml/XMLHttpR...
Source/core/xml/XMLHttpRequest.cpp:1387: if (m_error)
This looks redundant. Can changeState cancel the XHR?

[tyoshino (SeeGerritForStatus), 2014-06-04 04:39:50]

https://codereview.chromium.org/311593002/diff/40001/Source/core/xml/XMLHttpR...
File Source/core/xml/XMLHttpRequest.cpp (right):

https://codereview.chromium.org/311593002/diff/40001/Source/core/xml/XMLHttpR...
Source/core/xml/XMLHttpRequest.cpp:859: if (responseTypeCode() ==
ResponseTypeBlob)
On 2014/06/02 16:59:51, Nate Chapin wrote:
> Can we combine the two blob cases in this function, just to keep them
together?

Done.

https://codereview.chromium.org/311593002/diff/40001/Source/core/xml/XMLHttpR...
Source/core/xml/XMLHttpRequest.cpp:1387: if (m_error)
On 2014/06/02 16:59:51, Nate Chapin wrote:
> This looks redundant. Can changeState cancel the XHR?

Yes. We need this. changeState() calls readystatechange handler synchronously.
If abort() is called inside it, it's possible m_error is true here even when it
was false at L 1378.

Added comment.

[tyoshino (SeeGerritForStatus), 2014-06-04 04:40:01]

The CQ bit was checked by tyoshino@chromium.org

[commit-bot: I haz the power, 2014-06-04 04:40:30]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/tyoshino@chromium.org/311593002/80001

[commit-bot: I haz the power, 2014-06-04 05:49:22]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  blink_presubmit on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/6887)
  linux_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/1...)
  mac_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/10204)
  win_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/10532)

[commit-bot: I haz the power, 2014-06-04 06:12:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-04 06:12:28]

Try jobs failed on following builders:
  linux_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/1...)

[tyoshino (SeeGerritForStatus), 2014-06-04 06:17:41]

The CQ bit was checked by tyoshino@chromium.org

[commit-bot: I haz the power, 2014-06-04 06:17:59]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/tyoshino@chromium.org/311593002/80001

[commit-bot: I haz the power, 2014-06-04 06:42:36]

Change committed as 175446