Chromium Code Reviews
Help | Chromium Project | Sign in
(645)

Issue 3115026: Memory leak in remoting::SessionManagerTest_OneRecordCycle_Test (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 9 months ago by dhollowa
Modified:
4 years ago
CC:
chromium-reviews, Timur Iskhodzhanov, Alexander Potapenko, pam+watch_chromium.org, stuartmorgan+watch_chromium.org
Visibility:
Public.

Description

Memory leak in remoting::SessionManagerTest_OneRecordCycle_Test Adds suppression for Chromoting leak. http://build.chromium.org/buildbot/memory/builders/Chromium%20Mac%20(valgrind)/builds/7228/steps/memory%20test:%20remoting/logs/stdio Suppression (error hash=#FFFFFFFFE328E394#): { <insert_a_suppression_name_here> Memcheck:Leak fun:_Znw* fun:_Z11NewCallbackIN8remoting14SessionManagerEPNS0_21ChromotingHostMessageEiEPN9Callback2IT0_T1_E4TypeEPT_MSA_FvS5_S6_E fun:_ZN8remoting14SessionManager8DoEncodeE13scoped_refptrINS_11CaptureDataEE fun:_Z16DispatchToMethodIN8remoting14SessionManagerEMS1_Fv13scoped_refptrINS0_11CaptureDataEEES4_EvPT_T0_RK6Tuple1IT1_E fun:_ZN14RunnableMethodIN8remoting14SessionManagerEMS1_Fv13scoped_refptrINS0_11CaptureDataEEE6Tuple1IS4_EE3RunEv fun:_ZN11MessageLoop7RunTaskEP4Task fun:_ZN11MessageLoop21DeferOrRunPendingTaskERKNS_11PendingTaskE fun:_ZN11MessageLoop6DoWorkEv fun:_ZN4base18MessagePumpDefault3RunEPNS_11MessagePump8DelegateE fun:_ZN11MessageLoop11RunInternalEv fun:_ZN11MessageLoop10RunHandlerEv fun:_ZN11MessageLoop13RunAllPendingEv fun:_ZN8remoting38SessionManagerTest_OneRecordCycle_Test8TestBodyEv } BUG=53277 TEST=Valgrind on Mac turns green. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=57280

Patch Set 1 #

Patch Set 2 : Eliding. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -0 lines) Patch
M tools/valgrind/memcheck/suppressions_mac.txt View 1 1 chunk +12 lines, -0 lines 0 comments Download
Trybot results:
Commit: CQ not working?

Messages

Total messages: 4 (0 generated)
dhollowa
4 years, 9 months ago (2010-08-25 02:11:15 UTC) #1
Lei Zhang
LGTM You can probably replaces the frames between fun:_ZN11MessageLoop7RunTaskEP4Task and fun:_ZN8remoting38SessionManagerTest_OneRecordCycle_Test8TestBodyEv with '...'
4 years, 9 months ago (2010-08-25 02:14:16 UTC) #2
dhollowa
On 2010/08/25 02:14:16, Lei Zhang wrote: > LGTM > > You can probably replaces the ...
4 years, 9 months ago (2010-08-25 02:17:02 UTC) #3
rohitrao (OOO until 6-22)
4 years, 9 months ago (2010-08-25 02:18:11 UTC) #4
How do you know which lines need to stay and which lines are safe to "..."?
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld ec887be