Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Issue 311463002: Fixes possible crash in CursorHeightProvider (Closed)

Created:
6 years, 6 months ago by sky
Modified:
6 years, 6 months ago
Reviewers:
ananta
CC:
chromium-reviews, tfarina, ben+corewm_chromium.org, Mateusz SzymaƄski
Visibility:
Public.

Description

Fixes possible crash in CursorHeightProvider Crash data seems to indicate GetSystemMetrics(SM_CYCURSOR) can return a value bigger than the bitmap height. Go figure. BUG=378848 TEST=none R=ananta@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274001

Patch Set 1 #

Patch Set 2 : include and cast #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M ui/views/corewm/cursor_height_provider_win.cc View 1 2 chunks +4 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
sky
6 years, 6 months ago (2014-05-30 18:06:56 UTC) #1
ananta
lgtm
6 years, 6 months ago (2014-05-30 18:18:02 UTC) #2
sky
The CQ bit was checked by sky@chromium.org
6 years, 6 months ago (2014-05-30 18:25:17 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sky@chromium.org/311463002/20001
6 years, 6 months ago (2014-05-30 18:28:49 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_rel on tryserver.chromium ...
6 years, 6 months ago (2014-05-31 00:09:43 UTC) #5
commit-bot: I haz the power
6 years, 6 months ago (2014-05-31 03:56:40 UTC) #6
Message was sent while issue was closed.
Change committed as 274001

Powered by Google App Engine
This is Rietveld 408576698