Allow SkPictureImageFilter to be serialized when not run cross-process.

Allow SkPictureImageFilter to be serialized when not run cross-process.

Picture serialization is not yet hardened, but it turns out we do need
serialization of SkPictureImageFilter for deferred SVG-on-SVG filters,
since the SkPaints (and thus the SkImageFilters) are serialized by
SkPictureRecord. However, deferred filters are always drawn in the
same process, so we can safely serialize them in this case. We do this
by turning the compile-time check for
SK_ALLOW_PICTUREIMAGEFILTER_SERIALIZATION to a runtime check for
isCrossProcess().

The image filter fuzzer sample was also modified to enable fuzzing
of basic picture image filters (the code had rotted a bit, being behind
an #ifdef that no one sets).

BUG=375162
R=sugoi@google.com

Committed: https://code.google.com/p/skia/source/detail?r=15008

[Stephen White, 2014-05-30 19:14:54]

PTAL. Thanks!

[sugoi, 2014-05-30 20:24:45]

https://codereview.chromium.org/311443003/diff/1/samplecode/SampleFilterFuzz.cpp
File samplecode/SampleFilterFuzz.cpp (right):

https://codereview.chromium.org/311443003/diff/1/samplecode/SampleFilterFuzz....
samplecode/SampleFilterFuzz.cpp:386: recorder.endRecording();
missing "pict = " ?

https://codereview.chromium.org/311443003/diff/1/src/effects/SkPictureImageFi...
File src/effects/SkPictureImageFilter.cpp (right):

https://codereview.chromium.org/311443003/diff/1/src/effects/SkPictureImageFi...
src/effects/SkPictureImageFilter.cpp:42: buffer.readBool();
should we check that it's false to make sure we're not trying to send something
and then ignoring it?

https://codereview.chromium.org/311443003/diff/1/src/effects/SkPictureImageFi...
src/effects/SkPictureImageFilter.cpp:49: if (!buffer.isCrossProcess()) {
could be a bit shorter:
bool hasPicture = !buffer.isCrossProcess() && (fPicture != NULL);
buffer.writeBool(hasPicture);
if (hasPicture) {
    fPicture->flatten(buffer);
}

[Stephen White, 2014-05-30 20:32:37]

On 2014/05/30 20:24:45, sugoi wrote:
>
https://codereview.chromium.org/311443003/diff/1/samplecode/SampleFilterFuzz.cpp
> File samplecode/SampleFilterFuzz.cpp (right):
> 
>
https://codereview.chromium.org/311443003/diff/1/samplecode/SampleFilterFuzz....
> samplecode/SampleFilterFuzz.cpp:386: recorder.endRecording();
> missing "pict = " ?

Good catch; fixed.

>
https://codereview.chromium.org/311443003/diff/1/src/effects/SkPictureImageFi...
> File src/effects/SkPictureImageFilter.cpp (right):
> 
>
https://codereview.chromium.org/311443003/diff/1/src/effects/SkPictureImageFi...
> src/effects/SkPictureImageFilter.cpp:42: buffer.readBool();
> should we check that it's false to make sure we're not trying to send
something
> and then ignoring it?

Good idea; done.
>
https://codereview.chromium.org/311443003/diff/1/src/effects/SkPictureImageFi...
> src/effects/SkPictureImageFilter.cpp:49: if (!buffer.isCrossProcess()) {
> could be a bit shorter:
> bool hasPicture = !buffer.isCrossProcess() && (fPicture != NULL);
> buffer.writeBool(hasPicture);
> if (hasPicture) {
>     fPicture->flatten(buffer);
> }

I'd prefer to leave it as is, for symmetry with the reader code.

[sugoi, 2014-05-30 20:36:22]

LGTM

[Stephen White, 2014-05-30 20:51:00]

Committed patchset #5 manually as r15008 (presubmit successful).