Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Issue 311433006: Revert of Depend on v8:v8 instead of v8:mksnapshot (Closed)

Created:
6 years, 6 months ago by jochen (gone - plz use gerrit)
Modified:
6 years, 6 months ago
Reviewers:
brettw
CC:
chromium-reviews
Visibility:
Public.

Description

Revert of Depend on v8:v8 instead of v8:mksnapshot (https://codereview.chromium.org/302783009/) Reason for revert: need to revert v8 roll Original issue's description: > Depend on v8:v8 instead of v8:mksnapshot > > BUG=none > R=brettw@chromium.org > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274198 TBR=brettw@chromium.org NOTREECHECKS=true NOTRY=true BUG=none

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
jochen (gone - plz use gerrit)
Created Revert of Depend on v8:v8 instead of v8:mksnapshot
6 years, 6 months ago (2014-06-02 10:30:41 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jochen@chromium.org/311433006/1
6 years, 6 months ago (2014-06-02 10:31:08 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-02 10:32:29 UTC) #3
commit-bot: I haz the power
6 years, 6 months ago (2014-06-02 10:32:29 UTC) #4
Failed to apply patch for BUILD.gn:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file BUILD.gn
  Hunk #1 FAILED at 78.
  1 out of 1 hunk FAILED -- saving rejects to file BUILD.gn.rej

Patch:       BUILD.gn
Index: BUILD.gn
diff --git a/BUILD.gn b/BUILD.gn
index
ef9390d8a3d7c7af468e64b1f8672af0845501de..3bb1f117e0af3546c6db54c3a814642fa81333b4
100644
--- a/BUILD.gn
+++ b/BUILD.gn
@@ -78,7 +78,7 @@
     "//ui/strings",
     "//ui/surface",
     "//url",
-    "//v8:v8",
+    "//v8:mksnapshot",
   ]
 
   if (is_linux) {

Powered by Google App Engine
This is Rietveld 408576698