mojo/services/public/cpp/view_manager/lib/view_tree_node.cc - Issue 311423003: Provide an API to the example window manager app that supports closing a window.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/services/public/cpp/view_manager/lib/view_tree_node.cc

Issue 311423003: Provide an API to the example window manager app that supports closing a window. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: . Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« mojo/examples/embedded_app/embedded_app.cc ('K') | « mojo/services/public/cpp/view_manager/lib/view_manager_synchronizer.cc ('k') | mojo/services/public/cpp/view_manager/tests/view_manager_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: mojo/services/public/cpp/view_manager/lib/view_tree_node.cc

diff --git a/mojo/services/public/cpp/view_manager/lib/view_tree_node.cc b/mojo/services/public/cpp/view_manager/lib/view_tree_node.cc

index 03628acb7fc47c065c4626a291ab8e5ed5653003..7da69209528f0524a451893848b2714140092489 100644

--- a/mojo/services/public/cpp/view_manager/lib/view_tree_node.cc

+++ b/mojo/services/public/cpp/view_manager/lib/view_tree_node.cc

@@ -286,11 +286,15 @@ ViewTreeNode::ViewTreeNode()

active_view_(NULL) {}

ViewTreeNode::~ViewTreeNode() {

- ScopedDestructionNotifier notifier(this);

- if (parent_)

- parent_->LocalRemoveChild(this);

- if (manager_)

- ViewManagerPrivate(manager_).RemoveNode(id_);

+ {

+ // TODO(beng): I'm not sure I like these scoped destruction notifiers.

+ // When they fall out of scope |this| is toast.

+ ScopedDestructionNotifier notifier(this);

+ if (parent_)

+ parent_->LocalRemoveChild(this);

+ if (manager_)

+ ViewManagerPrivate(manager_).RemoveNode(id_);

+ }

}

////////////////////////////////////////////////////////////////////////////////