Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(240)

Issue 311423003: Provide an API to the example window manager app that supports closing a window. (Closed)

Created:
6 years, 6 months ago by Ben Goodger (Google)
Modified:
6 years, 6 months ago
Reviewers:
sky
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Visibility:
Public.

Description

Provide an API to the example window manager app that supports closing a window. Listen for clicks in the embedded app and close the corresponding view when clicked. R=sky@chromium.org http://crbug.com/365012 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275322

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Patch Set 4 : . #

Patch Set 5 : . #

Patch Set 6 : . #

Total comments: 2

Patch Set 7 : . #

Patch Set 8 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+173 lines, -48 lines) Patch
A + mojo/examples/embedded_app/DEPS View 0 chunks +-1 lines, --1 lines 0 comments Download
M mojo/examples/embedded_app/embedded_app.cc View 1 2 3 4 5 6 7 2 chunks +59 lines, -14 lines 0 comments Download
A + mojo/examples/window_manager/DEPS View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M mojo/examples/window_manager/window_manager.cc View 1 2 3 4 5 1 chunk +64 lines, -12 lines 0 comments Download
A + mojo/examples/window_manager/window_manager.mojom View 1 chunk +2 lines, -3 lines 0 comments Download
M mojo/mojo_examples.gypi View 3 chunks +16 lines, -0 lines 0 comments Download
M mojo/services/public/cpp/view_manager/lib/view_manager.cc View 1 2 3 4 5 4 chunks +12 lines, -8 lines 0 comments Download
M mojo/services/public/cpp/view_manager/lib/view_manager_private.cc View 1 2 3 1 chunk +6 lines, -2 lines 0 comments Download
M mojo/services/public/cpp/view_manager/lib/view_manager_synchronizer.cc View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M mojo/services/public/cpp/view_manager/tests/view_manager_unittest.cc View 1 5 chunks +6 lines, -5 lines 0 comments Download
M mojo/services/public/cpp/view_manager/view_manager.h View 1 2 3 4 5 2 chunks +9 lines, -6 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Ben Goodger (Google)
https://codereview.chromium.org/311423003/diff/100001/mojo/examples/embedded_app/embedded_app.cc File mojo/examples/embedded_app/embedded_app.cc (right): https://codereview.chromium.org/311423003/diff/100001/mojo/examples/embedded_app/embedded_app.cc#newcode63 mojo/examples/embedded_app/embedded_app.cc:63: views_to_reap_[node] = old_view; I have to do this because ...
6 years, 6 months ago (2014-06-05 22:35:42 UTC) #1
sky
LGTM https://codereview.chromium.org/311423003/diff/100001/mojo/examples/embedded_app/embedded_app.cc File mojo/examples/embedded_app/embedded_app.cc (right): https://codereview.chromium.org/311423003/diff/100001/mojo/examples/embedded_app/embedded_app.cc#newcode63 mojo/examples/embedded_app/embedded_app.cc:63: views_to_reap_[node] = old_view; On 2014/06/05 22:35:42, Ben Goodger ...
6 years, 6 months ago (2014-06-05 22:51:31 UTC) #2
Ben Goodger (Google)
6 years, 6 months ago (2014-06-06 04:50:42 UTC) #3
Message was sent while issue was closed.
Committed patchset #8 manually as r275322 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698