Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3047)

Unified Diff: chrome/browser/net/connection_tester.cc

Issue 311393002: Add URLRequestJobFactories to URLRequestContexts without one. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Add two more that aren't tested Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/io_thread.cc ('k') | chrome/browser/net/connection_tester_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/net/connection_tester.cc
diff --git a/chrome/browser/net/connection_tester.cc b/chrome/browser/net/connection_tester.cc
index 533f8acb11831cf47c0da40c6ffa14bac2c2f8d0..9f80e18c2b509808daff0ad6b26f3e82e1d6dee4 100644
--- a/chrome/browser/net/connection_tester.cc
+++ b/chrome/browser/net/connection_tester.cc
@@ -36,6 +36,7 @@
#include "net/url_request/url_request.h"
#include "net/url_request/url_request_context.h"
#include "net/url_request/url_request_context_storage.h"
+#include "net/url_request/url_request_job_factory_impl.h"
#if !defined(OS_ANDROID) && !defined(OS_IOS)
#include "chrome/browser/net/firefox_proxy_settings.h"
@@ -134,6 +135,8 @@ class ExperimentURLRequestContext : public net::URLRequestContext {
// In-memory cookie store.
storage_.set_cookie_store(
content::CreateCookieStore(content::CookieStoreConfig()));
+ // Creating a new job factory avoids all URLRequestInterceptors.
pauljensen 2014/06/10 16:20:19 I'm not sure I understand this comment. URLReques
mmenke 2014/06/10 16:26:28 Comment updated. Wrote the comment before the CL
+ storage_.set_job_factory(new net::URLRequestJobFactoryImpl());
return net::OK;
}
« no previous file with comments | « chrome/browser/io_thread.cc ('k') | chrome/browser/net/connection_tester_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698