Add URLRequestJobFactories to URLRequestContexts without one.

Add URLRequestJobFactories to URLRequestContexts without one.

Currently a URLRequestJobFactory is optional, as the global
URLRequestJobManager passes jobs on to the URLRequestFilter and
global http/https/ws/wss factories.  In order to be able to
eliminate the global URLRequestJobManager object, first have to
give all contexts their own URLRequestJobFactory.

BUG=81979
TBR=ajwong@chromium.org (Who actually signed off on this, but Rietveld ignored his email).

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276867

[mmenke, 2014-06-06 18:25:56]

I think I got all the ones that do URL requests (I skipped a couple in net tests
that don't actually issue requests), but as I tear down URLRequestManager, it's
still possible things I missed will turn up.

[pauljensen, 2014-06-10 16:20:19]

lgtm with the one clarification

https://codereview.chromium.org/311393002/diff/60001/chrome/browser/net/conne...
File chrome/browser/net/connection_tester.cc (right):

https://codereview.chromium.org/311393002/diff/60001/chrome/browser/net/conne...
chrome/browser/net/connection_tester.cc:138: // Creating a new job factory
avoids all URLRequestInterceptors.
I'm not sure I understand this comment.  URLRequestInterceptors added through
URLRequestFilter are not avoided, also g_interceptor_for_testing is not avoided.

[mmenke, 2014-06-10 16:26:28]

Thanks!

https://codereview.chromium.org/311393002/diff/60001/chrome/browser/net/conne...
File chrome/browser/net/connection_tester.cc (right):

https://codereview.chromium.org/311393002/diff/60001/chrome/browser/net/conne...
chrome/browser/net/connection_tester.cc:138: // Creating a new job factory
avoids all URLRequestInterceptors.
On 2014/06/10 16:20:19, pauljensen wrote:
> I'm not sure I understand this comment.  URLRequestInterceptors added through
> URLRequestFilter are not avoided, also g_interceptor_for_testing is not
avoided.

Comment updated.  Wrote the comment before the CL to make the filter use
interceptors.  It avoids the interceptors attached to
URLRequestInterceptingJobFactories.

[pauljensen, 2014-06-10 16:56:22]

On 2014/06/10 16:26:28, mmenke wrote:
> Comment updated.  Wrote the comment before the CL to make the filter use
> interceptors.  It avoids the interceptors attached to
> URLRequestInterceptingJobFactories.

Weren't these avoided previously by not having any URLRequestJobFactories, as
URLRequestInterceptingJobFactories were themselves URLRequestJobFactories?

[mmenke, 2014-06-10 18:53:17]

On 2014/06/10 16:56:22, pauljensen wrote:
> On 2014/06/10 16:26:28, mmenke wrote:
> > Comment updated.  Wrote the comment before the CL to make the filter use
> > interceptors.  It avoids the interceptors attached to
> > URLRequestInterceptingJobFactories.
> 
> Weren't these avoided previously by not having any URLRequestJobFactories, as
> URLRequestInterceptingJobFactories were themselves URLRequestJobFactories?

Basically.  This was avoided by not having a URLRequestJobFactory, as the
URLRequestJobManager itself creates HTTP/HTTPS jobs as well as
URLRequest::ProtocolFactories, like the URLRequestFilter.  With
URLRequestJobManager going away, of course, that will no longer work.

[mmenke, 2014-06-10 18:57:24]

thestig:  Please review browser/ changes.

ajwong:  Please review service/ changes.

sergeyu:  Please review remoting/ changes.

haitaol:  Please review sync/ changes.

Thanks!

[mmenke, 2014-06-10 18:57:55]

On 2014/06/10 18:57:24, mmenke wrote:
> thestig:  Please review browser/ changes.

thestig:  Sorry, just need to review browser/io_thread.*  Thanks!

[Lei Zhang, 2014-06-10 19:08:11]

c/b/io_threads* lgtm

[haitaol1, 2014-06-10 19:14:14]

sync LGTM

[Sergey Ulanov, 2014-06-10 19:54:35]

remoting lgtm

[mmenke, 2014-06-11 21:32:19]

awong:  Ping!

[mmenke, 2014-06-12 18:22:49]

hclam:  Mind signing off on the (tiny) chrome/service/net/ changes?

[mmenke, 2014-06-12 19:03:15]

The CQ bit was checked by mmenke@chromium.org

[commit-bot: I haz the power, 2014-06-12 19:07:16]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/mmenke@chromium.org/311393002/80001

[commit-bot: I haz the power, 2014-06-13 00:41:33]

Change committed as 276867