Issue 311373005: Nesting

Issue 311373005: Nesting (Closed)

Created:
6 years, 6 months ago by Ben Goodger (Google)

Modified:
6 years, 6 months ago

Reviewers:
sky

CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Add an example that nests embedded app, so we have two levels of nesting (and thus two connections). I realized an error in understanding of ServiceConnection et al and have corrected this with this CL. ViewManager is now instantiated by the synchronizer. For a given app instance there may be N instances of ViewManager, one per unique connection. Code utilizing ViewManager needs to be more careful about which instance they pass. R=sky@chromium.org http://crbug.com/365012 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275609

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Total comments: 3

Patch Set 4 : . #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+235 lines, -122 lines)			Patch
M	mojo/examples/embedded_app/embedded_app.cc	View	1 2 3	4 chunks	+23 lines, -26 lines	0 comments	Download
A +	mojo/examples/nesting_app/DEPS	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
A	mojo/examples/nesting_app/nesting_app.cc	View	1 2 3	1 chunk	+78 lines, -0 lines	0 comments	Download
M	mojo/examples/window_manager/window_manager.cc	View	1 2 3	6 chunks	+43 lines, -28 lines	0 comments	Download
M	mojo/mojo.gyp	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	mojo/mojo_examples.gypi	View	1	1 chunk	+22 lines, -0 lines	0 comments	Download
M	mojo/mojo_services.gypi	View	1 2 3	1 chunk	+1 line, -0 lines	0 comments	Download
M	mojo/services/public/cpp/view_manager/lib/view_manager.cc	View	1 2	3 chunks	+7 lines, -34 lines	0 comments	Download
M	mojo/services/public/cpp/view_manager/lib/view_manager_private.cc	View	1 2 3	3 chunks	+3 lines, -4 lines	0 comments	Download
M	mojo/services/public/cpp/view_manager/lib/view_manager_synchronizer.h	View	1 2	2 chunks	+3 lines, -1 line	0 comments	Download
M	mojo/services/public/cpp/view_manager/lib/view_manager_synchronizer.cc	View	1 2	2 chunks	+2 lines, -5 lines	0 comments	Download
M	mojo/services/public/cpp/view_manager/tests/view_manager_unittest.cc	View	1 2 3	4 chunks	+17 lines, -7 lines	0 comments	Download
M	mojo/services/public/cpp/view_manager/view_manager.h	View	1 2 3	2 chunks	+10 lines, -18 lines	0 comments	Download
A	mojo/services/public/cpp/view_manager/view_manager_delegate.h	View	1 2 3	1 chunk	+26 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Ben Goodger (Google)

https://codereview.chromium.org/311373005/diff/40001/mojo/services/public/cpp/view_manager/view_manager.h File mojo/services/public/cpp/view_manager/view_manager.h (right): https://codereview.chromium.org/311373005/diff/40001/mojo/services/public/cpp/view_manager/view_manager.h#newcode36 mojo/services/public/cpp/view_manager/view_manager.h:36: class ViewManager { I think that after this change, ...

6 years, 6 months ago (2014-06-06 19:55:46 UTC) #1

sky

LGTM https://codereview.chromium.org/311373005/diff/40001/mojo/examples/nesting_app/nesting_app.cc File mojo/examples/nesting_app/nesting_app.cc (right): https://codereview.chromium.org/311373005/diff/40001/mojo/examples/nesting_app/nesting_app.cc#newcode26 mojo/examples/nesting_app/nesting_app.cc:26: class NestingApp : public Application, nit: add description. ...

6 years, 6 months ago (2014-06-06 20:02:07 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ben@chromium.org/311373005/60001

6 years, 6 months ago (2014-06-06 23:22:59 UTC) #4

commit-bot: I haz the power

FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_rel on tryserver.chromium ...

6 years, 6 months ago (2014-06-07 00:46:22 UTC) #5

Message was sent while issue was closed.

Change committed as 275609

Expand Messages | Collapse Messages