Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Issue 311373003: Fix Assert for gpu ConicalTwoPointGradient edgecase to be correct bounds. (Closed)

Created:
6 years, 6 months ago by egdaniel
Modified:
6 years, 6 months ago
Reviewers:
bsalomon
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Fix Assert for gpu ConicalTwoPointGradient edgecase to be correct bounds. BUG=skia: Committed: https://skia.googlesource.com/skia/+/8405ef9854858b2527bf03b7e7abb1c0da59411d

Patch Set 1 #

Patch Set 2 : Fix assert to check if zero start rad #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -7 lines) Patch
M gm/gradients_2pt_conical.cpp View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/effects/gradients/SkTwoPointConicalGradient_gpu.cpp View 1 4 chunks +12 lines, -7 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
egdaniel
Ran into a bug from my old gradient stuff. Basically when determining whether or not ...
6 years, 6 months ago (2014-06-05 20:36:50 UTC) #1
bsalomon
lgtm
6 years, 6 months ago (2014-06-05 20:44:55 UTC) #2
egdaniel
The CQ bit was checked by egdaniel@google.com
6 years, 6 months ago (2014-06-06 13:30:56 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/egdaniel@google.com/311373003/1
6 years, 6 months ago (2014-06-06 13:31:23 UTC) #4
commit-bot: I haz the power
Change committed as be4fd4f7349b97a7c34a4177ec26d8aea9616628
6 years, 6 months ago (2014-06-06 14:26:20 UTC) #5
egdaniel
A revert of this CL has been created in https://codereview.chromium.org/320573002/ by egdaniel@google.com. The reason for ...
6 years, 6 months ago (2014-06-06 14:46:23 UTC) #6
egdaniel
Fix to my fix of the assert. Now passing a subset of the bots that ...
6 years, 6 months ago (2014-06-09 18:14:18 UTC) #7
bsalomon
lgtm
6 years, 6 months ago (2014-06-09 18:17:09 UTC) #8
egdaniel
The CQ bit was checked by egdaniel@google.com
6 years, 6 months ago (2014-06-09 18:24:10 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/egdaniel@google.com/311373003/20001
6 years, 6 months ago (2014-06-09 18:24:26 UTC) #10
commit-bot: I haz the power
6 years, 6 months ago (2014-06-09 18:57:33 UTC) #11
Message was sent while issue was closed.
Change committed as 8405ef9854858b2527bf03b7e7abb1c0da59411d

Powered by Google App Engine
This is Rietveld 408576698