Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Issue 311363002: Accept up to 60fps frame rate in MediaStreamVideoCapturerSource (Closed)

Created:
6 years, 6 months ago by mcasas
Modified:
6 years, 6 months ago
CC:
chromium-reviews, fischman+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, wjia+watch_chromium.org, DaleCurtis
Visibility:
Public.

Description

Accept up to 60fps frame rate in MediaStreamVideoCapturerSource. MSVCS has a list of by-default supported capture formats |kVideoFormats| used as a fallback for sources that don't support capability enumeration. It's composed of a couple of resolutions and a fixed frame rate of 30. This CL adds also 60 fps to the fallback list, so the user can select frame rates over 30, e.g. by setting min=54 and max=54. BUG=381225 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275290

Patch Set 1 : #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -15 lines) Patch
M content/renderer/media/media_stream_video_capturer_source.cc View 1 2 chunks +17 lines, -15 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
mcasas
dalecurtis@ PTAL. (tommi@ FYI).
6 years, 6 months ago (2014-06-05 17:26:06 UTC) #1
DaleCurtis
I'm not the right primary reviewer for this. You should find someone on the capture ...
6 years, 6 months ago (2014-06-05 18:01:50 UTC) #2
tommi (sloooow) - chröme
lgtm. Dale - what are the unforeseen consequences you're thinking of? Miguel - can you ...
6 years, 6 months ago (2014-06-05 19:58:00 UTC) #3
DaleCurtis
I probably just don't understand this code, which is another reason I shouldn't be the ...
6 years, 6 months ago (2014-06-05 20:06:33 UTC) #4
mcasas
On 2014/06/05 20:06:33, DaleCurtis wrote: > I probably just don't understand this code, which is ...
6 years, 6 months ago (2014-06-05 20:39:15 UTC) #5
mcasas
The CQ bit was checked by mcasas@chromium.org
6 years, 6 months ago (2014-06-05 20:40:05 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mcasas@chromium.org/311363002/40001
6 years, 6 months ago (2014-06-05 20:42:44 UTC) #7
commit-bot: I haz the power
6 years, 6 months ago (2014-06-06 01:16:07 UTC) #8
Message was sent while issue was closed.
Change committed as 275290

Powered by Google App Engine
This is Rietveld 408576698