Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(531)

Issue 311353004: Disable slow tests on debug build. (Closed)

Created:
6 years, 6 months ago by fukino
Modified:
6 years, 6 months ago
Reviewers:
kinaba
CC:
chromium-reviews, nkostylev+watch_chromium.org, yoshiki+watch_chromium.org, rginda+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

Disable slow tests on debug build. Browser tests get time-out on debug build and close the tree frequently. This CL disable slow tests which got time-out at least once in the last month on debug build. BUG=327719 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275426

Patch Set 1 #

Total comments: 2

Patch Set 2 : Rebase and disable OpenAudioFiles test on debug build. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+181 lines, -70 lines) Patch
M chrome/browser/chromeos/file_manager/file_manager_browsertest.cc View 1 9 chunks +181 lines, -70 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
fukino
kinaba san, could you take a look? the macro WRAPPED_INSTANTIATE_TEST_CASE_P is defined in both this ...
6 years, 6 months ago (2014-06-06 07:18:24 UTC) #1
kinaba
lgtm https://codereview.chromium.org/311353004/diff/1/chrome/browser/chromeos/file_manager/file_manager_browsertest.cc File chrome/browser/chromeos/file_manager/file_manager_browsertest.cc (right): https://codereview.chromium.org/311353004/diff/1/chrome/browser/chromeos/file_manager/file_manager_browsertest.cc#newcode809 chrome/browser/chromeos/file_manager/file_manager_browsertest.cc:809: DISABLED_OpenAudioFiles, I reenabled the test in ToT. Could ...
6 years, 6 months ago (2014-06-06 07:32:59 UTC) #2
fukino
https://codereview.chromium.org/311353004/diff/1/chrome/browser/chromeos/file_manager/file_manager_browsertest.cc File chrome/browser/chromeos/file_manager/file_manager_browsertest.cc (right): https://codereview.chromium.org/311353004/diff/1/chrome/browser/chromeos/file_manager/file_manager_browsertest.cc#newcode809 chrome/browser/chromeos/file_manager/file_manager_browsertest.cc:809: DISABLED_OpenAudioFiles, On 2014/06/06 07:32:59, kinaba wrote: > I reenabled ...
6 years, 6 months ago (2014-06-06 10:56:57 UTC) #3
fukino
The CQ bit was checked by fukino@chromium.org
6 years, 6 months ago (2014-06-06 10:57:27 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fukino@chromium.org/311353004/20001
6 years, 6 months ago (2014-06-06 11:00:00 UTC) #5
commit-bot: I haz the power
6 years, 6 months ago (2014-06-06 13:32:16 UTC) #6
Message was sent while issue was closed.
Change committed as 275426

Powered by Google App Engine
This is Rietveld 408576698