Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1304)

Issue 311353002: Add support for JSON output to checklicenses.py (Closed)

Created:
6 years, 6 months ago by Paweł Hajdan Jr.
Modified:
6 years, 6 months ago
Reviewers:
M-A Ruel
CC:
chromium-reviews
Visibility:
Public.

Description

Add support for JSON output to checklicenses.py BUG=128664 R=maruel@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275147

Patch Set 1 #

Total comments: 4

Patch Set 2 : iterkeys #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -14 lines) Patch
M tools/checklicenses/checklicenses.py View 1 5 chunks +23 lines, -14 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Paweł Hajdan Jr.
6 years, 6 months ago (2014-06-05 14:21:35 UTC) #1
M-A Ruel
lgtm with two things fixed. https://codereview.chromium.org/311353002/diff/1/tools/checklicenses/checklicenses.py File tools/checklicenses/checklicenses.py (right): https://codereview.chromium.org/311353002/diff/1/tools/checklicenses/checklicenses.py#newcode459 tools/checklicenses/checklicenses.py:459: with open(options.json, 'w') as ...
6 years, 6 months ago (2014-06-05 15:01:46 UTC) #2
Paweł Hajdan Jr.
https://codereview.chromium.org/311353002/diff/1/tools/checklicenses/checklicenses.py File tools/checklicenses/checklicenses.py (right): https://codereview.chromium.org/311353002/diff/1/tools/checklicenses/checklicenses.py#newcode459 tools/checklicenses/checklicenses.py:459: with open(options.json, 'w') as f: On 2014/06/05 15:01:47, M-A ...
6 years, 6 months ago (2014-06-05 15:38:14 UTC) #3
M-A Ruel
lgtm
6 years, 6 months ago (2014-06-05 15:43:29 UTC) #4
Paweł Hajdan Jr.
6 years, 6 months ago (2014-06-05 16:20:35 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r275147 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698