Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Issue 311343006: [chromedriver] Change Chrome log level from 1 to 0. (Closed)

Created:
6 years, 6 months ago by samuong
Modified:
6 years, 6 months ago
Reviewers:
craigdh
CC:
chromium-reviews, stgao
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

[chromedriver] Change Chrome log level from 1 to 0. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275515

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/test/chromedriver/chrome_launcher.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
samuong
This fixes testChromeLogPath, which has been failing on Mac and Linux builders since r274729. PTAL. ...
6 years, 6 months ago (2014-06-06 04:29:02 UTC) #1
samuong
Shuotao is OOTO so sending to Craig for review.
6 years, 6 months ago (2014-06-06 16:51:55 UTC) #2
craigdh
lgtm.
6 years, 6 months ago (2014-06-06 16:53:19 UTC) #3
samuong
The CQ bit was checked by samuong@chromium.org
6 years, 6 months ago (2014-06-06 16:54:12 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/samuong@chromium.org/311343006/1
6 years, 6 months ago (2014-06-06 16:55:37 UTC) #5
commit-bot: I haz the power
6 years, 6 months ago (2014-06-06 20:39:43 UTC) #6
Message was sent while issue was closed.
Change committed as 275515

Powered by Google App Engine
This is Rietveld 408576698